Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inspect tab to compose #3316

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Jul 24, 2023

What does this PR do?

  • Adds the inspect tab to Compose which is an array of "container
    inspect" from docker / podman.
  • Inspect is JSON array of containers, see
    docker-compose inspect docker/compose#4155 for inspiration (they
    don't actually have a compose inspect command..)
  • Adds tests

Screenshot/screencast of this PR

Screen.Recording.2023-07-24.at.12.38.35.PM.mov

What issues does this PR fix or reference?

Closes #3192

How to test this PR?

  1. Deploy a compose example
  2. Click on the compose group
  3. Select the inspect tab

Signed-off-by: Charlie Drage charlie@charliedrage.com

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

@cdrage cdrage requested review from a team and benoitf as code owners July 24, 2023 16:44
@cdrage cdrage requested review from jeffmaury and lstocchi and removed request for a team July 24, 2023 16:44
@cdrage
Copy link
Contributor Author

cdrage commented Jul 25, 2023

Fixing tests at the moment 🚗

@cdrage cdrage force-pushed the inspect-compose branch 2 times, most recently from 0c9dcd8 to d602a82 Compare July 25, 2023 15:26
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

👍

### What does this PR do?

* Adds the inspect tab to Compose which is an array of "container
  inspect" from docker / podman.
* Inspect is JSON array of containers, see
  docker/compose#4155 for inspiration (they
  don't actually have a `compose inspect` command..)
* Adds tests

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes podman-desktop#3192

### How to test this PR?

1. Deploy a compose example
2. Click on the compose group
3. Select the inspect tab

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage enabled auto-merge (squash) July 26, 2023 13:37
@cdrage cdrage merged commit 4c52dd5 into podman-desktop:main Jul 26, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.3.0 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compose: Inspect tab missing
3 participants