chore: drop patternfly #4762
chore: drop patternfly #4762
Conversation
also remove the overrides that were done on top of patternfly change default color of text to be white and bring font-awesome font/css before it was being provided through patternfly but as it is removed it was not there anymore fixes containers#1617 fixes containers#4319 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
jeffmaury,
cdrage and
deboer-tim
and removed request for
a team
|
@jeffmaury Try to fix all issues coming from dropping patternfly before the merge or merge early and do follow-up PRs to get all breakages being fixed. Also, do you prefer with the new font or with older font size |
No for me it's not a blocker just recording for later issues |
There was a problem hiding this comment.
The CSS override was setting a line height of 0.9rem, we might want to keep that for now just for less change and smaller screens.
I've been running with most of these changes or variants of them already and LGTM. I think we're close enough that it's better to switch early - more time for everyone to catch regressions, no risk of new dependencies on PF, benefits like single version of FA, etc.
|
ok let's merge it now then |
|
Here is what I got, on Linux: Before: After: The text is now invisible (until selected) |
|
thanks @afbjorklund |
fixes containers#4762 (comment) Signed-off-by: Florent Benoit <fbenoit@redhat.com>
fixes #4762 (comment) Signed-off-by: Florent Benoit <fbenoit@redhat.com>
What does this PR do?
All usage of patternfly have been dropped so it's time to be able to remove patternfly
I also remove the overrides that were done on top of patternfly as we no longer them
I changed default colour of text to be white and bring font-awesome font/css before it was being provided through patternfly but as it is removed it was not there anymore
we might have some little glitches this is why I wanted to get this merge long time before a new release so we have to identify them/fix them
We've lost the Redhat Font also, I don't know if we want to pickup another default font.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes #1617
fixes #4319
How to test this PR?
Look at the UI