fix: fix background colours after patternfly removal #4803
Conversation
fixes containers#4762 (comment) Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
dgolovin and
lstocchi
and removed request for
a team
There was a problem hiding this comment.
I'm good with this.
Makes me wonder if there's an issue with the dark mode setting, but also that we will need to do Text component at some point (#3234).
|
so for now there is no "light/dark" mode in Podman Desktop so it takes default colour and assume it'll take light colours. from now we'll be able to introduce context switching for colours and add specifics for light or dark |
My bad, I had seen this in the website and thought I was looking at the main tailwind cfg: Re: https://tailwindcss.com/docs/dark-mode
👍🏼. I think we should figure out how we're going to do the toggle and introduce a private feature flag for light mode soon, so that we can start exploring. |
After the PatternFly removal I noticed that the scrollbars on Mac are in light-mode. PF-dark was setting the color-scheme before, setting it again fixes the problem and means we can also remove the explicit text-white. (maybe some of the changes in #4803 too?) PF was also setting the line height to 0.9. I'm not tied to it, but it makes buttons, multi-line text, and preferences nav items all less tall. Maybe I'm just used to it, but I prefer a smaller window and 0.95 gets most of the way there & uses less space. Signed-off-by: Tim deBoer <git@tdeboer.ca>
What does this PR do?
background color was missing on some input
apply colors
Screenshot/screencast of this PR
you can see old look&feel in the referenced issue
how it looks in this PR:
What issues does this PR fix or reference?
fixes #4762 (comment)
How to test this PR?