Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flatpak creates Podman socket #860

Merged
merged 2 commits into from
Nov 18, 2022
Merged

fix: flatpak creates Podman socket #860

merged 2 commits into from
Nov 18, 2022

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Nov 18, 2022

What does this PR do?

flatpak creates Podman socket if it does not exist

Signed-off-by: Fabrice Flore-Thébault ffloreth@redhat.com

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fix #656

How to test this PR?

On Linux, running Podman Desktop flatpak, when the directory containing the podman socket doesn't exist, Podman Desktop creates the directory and the socket, but doesn't find it.

I could reproduce the issue with:

pkill flatpak-spawn ; rmdir /run/user/1000/podman/ ; flatpak run io.podman_desktop.PodmanDesktop/x86_64/main

I could not reproduce the issue while running:

yarn watch

Therefore, I believe flatpak behavior was the source of the problem.

To test: get the flatpak build artifact, and run:

pkill flatpak-spawn ; rmdir /run/user/1000/podman/ ; flatpak run io.podman_desktop.PodmanDesktop/x86_64/main

Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and confirmed (and discussed with Fabrice)

should really fix the issue now (in addition to the wait for the creation of the file)

IEK1qYfCnk.mp4

@themr0c
Copy link
Contributor Author

themr0c commented Nov 18, 2022

Thank you for the help and screencast @benoitf !

@benoitf benoitf merged commit 8d31cab into podman-desktop:main Nov 18, 2022
@podman-desktop-bot podman-desktop-bot added this to the 0.10.0 milestone Nov 18, 2022
@slemeur slemeur changed the title feat: flatpak creates Podman socket fix: flatpak creates Podman socket Nov 29, 2022
@themr0c themr0c deleted the feat-create-podman-socket branch April 14, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'No Container Engine' on linux
3 participants