Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openshift merge robot /lgtm #106

Open
baude opened this issue May 10, 2023 · 4 comments
Open

openshift merge robot /lgtm #106

baude opened this issue May 10, 2023 · 4 comments

Comments

@baude
Copy link
Member

baude commented May 10, 2023

Do folks want the openshift merge robot to help with merging and reviewing? speak up here.
@Luap99
Copy link
Member

Luap99 commented May 11, 2023

I never understand how the bot helps with merging? The only useful feature I can see is the cherry-pick functionality but this is definitely not needed on this repo.

@baude
Copy link
Member Author

baude commented May 11, 2023

it controls the whole /lgtm and approved stuff. cherry-picks like you said as well. if we actually used it properly, it could also do the ci jobs.

@Luap99
Copy link
Member

Luap99 commented May 11, 2023

Sure but why do I need /approve /lgtm, what benefit does it have? I can just press the button in the github interface instead. That at least doesn't have a delay like the bot.

@TomSweeneyRedHat
Copy link
Member

I'm fine with or without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@baude @TomSweeneyRedHat @Luap99