Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve swagger docs and mention which endpoints support auth headers #8993

Closed
towe75 opened this issue Jan 17, 2021 · 13 comments · Fixed by #10588
Closed

Improve swagger docs and mention which endpoints support auth headers #8993

towe75 opened this issue Jan 17, 2021 · 13 comments · Fixed by #10588
Assignees
Labels
documentation Issue or fix is in project documentation kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue volunteers-wanted Issues good for community/volunteer contributions

Comments

@towe75
Copy link
Contributor

towe75 commented Jan 17, 2021

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

Your HTTP API reference for libpod/images/pull at https://docs.podman.io/en/latest/_static/api.html#operation/libpodImagesPull includes a "credentials" query Parameter. But the handler at https://github.com/containers/podman/blob/v2.2/pkg/api/handlers/libpod/images_pull.go seems not to make use of it.

Following the bread crumps i would guess that we can rather user docker'ish X-Registry-Auth / X-Registry-Config Headers.
Please clarify and improve/fix the documentation if i'm right.

Further i am wondering how to use credential helpers correctly via HTTP API. I assume one has to configure global helpers via containers-auth.json and "it just works"? There is no way to influence/configure this via API, is it?

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 17, 2021
@vrothberg
Copy link
Member

Your HTTP API reference for libpod/images/pull at https://docs.podman.io/en/latest/_static/api.html#operation/libpodImagesPull includes a "credentials" query Parameter. But the handler at https://github.com/containers/podman/blob/v2.2/pkg/api/handlers/libpod/images_pull.go seems not to make use of it.

Following the bread crumps i would guess that we can rather user docker'ish X-Registry-Auth / X-Registry-Config Headers.
Please clarify and improve/fix the documentation if i'm right.

That's correct. Credentials can be set via the header.

Further i am wondering how to use credential helpers correctly via HTTP API. I assume one has to configure global helpers via containers-auth.json and "it just works"? There is no way to influence/configure this via API, is it?

Both are correct.

Thanks for reaching out. We should definitely fix that in the docs.

@towe75
Copy link
Contributor Author

towe75 commented Jan 22, 2021

@vrothberg thank you for info.

@vrothberg vrothberg changed the title How to use authenticate a libpod/images/pull API request? Improve swagger docs and mention which endpoints support auth headers Jan 25, 2021
@vrothberg vrothberg added documentation Issue or fix is in project documentation volunteers-wanted Issues good for community/volunteer contributions labels Jan 25, 2021
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Feb 26, 2021

@towe75 Interested in opening a PR to help fix the docs?

@towe75
Copy link
Contributor Author

towe75 commented Feb 26, 2021

@rhatdan i am actually tempted to cut some time in order to bring the podman project forward. But docs are certainly not my strength and i am not really familiar with the docker-way-of-auth, sorry. I can possibly help with setting up some ubuntu package tests via GH actions or having 2 ubuntu versions in the repo etc. I will ping you on some another channel when i'm ready, ok?

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Mar 30, 2021

@jwhonce PTAL at fixing these docs?

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jun 7, 2021

@cdoern PTAL

@cdoern
Copy link
Contributor

cdoern commented Jun 7, 2021

@rhatdan will do, I have actually been looking at something similar on the libpod end with platform query parameters.

@cdoern cdoern self-assigned this Jun 7, 2021
@cdoern cdoern linked a pull request Jun 16, 2021 that will close this issue
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jul 11, 2021

Looks like a bunch of fixes have merged, I am closing reopen if more need to be fixed.

@rhatdan rhatdan closed this as completed Jul 11, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Issue or fix is in project documentation kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue volunteers-wanted Issues good for community/volunteer contributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants