-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network create: add support for ipam-driver none #13701
Conversation
7b7f587
to
efbfa21
Compare
This needs containers/common#989 to make the new test work with CNI. |
@containers/podman-maintainers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
go.mod
Outdated
|
||
// builds are broken with selinux v1.10.1, see https://github.com/containers/buildah/pull/3875 | ||
// once PR is merged and vendored into podman we have to remove this | ||
replace github.com/opencontainers/selinux => github.com/opencontainers/selinux v1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already merged containers/buildah#3875 should we remove this ? However I think a vendor dance would be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#13733 will vendor in a new buildah version
Updating buildah in this PR is out of scope IMO
/hold |
Add a new flag to set the ipam-driver. Also adds a new ipam driver none mode which only creates interfaces but does not assign addresses. Fixes containers#13521 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@containers/podman-maintainers PTAL |
/lgtm |
Add a new flag to set the ipam-driver. Also adds a new ipam driver none
mode which only creates interfaces but does not assign addresses.
Fixes #13521