Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in opencontainers/selinux v1.10.1 #3875

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 29, 2022

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@rhatdan rhatdan force-pushed the selinux branch 2 times, most recently from 6d7f611 to 8c3a6d5 Compare March 29, 2022 20:03
@TomSweeneyRedHat
Copy link
Member

Changes LGTM, but we're having no luck at all vendoring today.... Tests are all unhappy.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @rhatdan But wouldn't it cause issue if it points to another similar symlink however not sure if that is possible in case of /proc/self/fd/%d

@rhatdan
Copy link
Member Author

rhatdan commented Apr 2, 2022

@flouthoc perhaps, but this duplicates what would have happened before the fix in opencontainers/selinux.

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, restarted flakes @nalind PTAL

@flouthoc
Copy link
Collaborator

flouthoc commented Apr 4, 2022

@rhatdan Test bud stdio is usable pipes which exercises this part of code is failing. Could you PTAL.
Test was added here: #3630

/hold till relevent test passes

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@flouthoc
Copy link
Collaborator

flouthoc commented Apr 4, 2022

LGTM

/hold cancel

@flouthoc
Copy link
Collaborator

flouthoc commented Apr 4, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [flouthoc,giuseppe,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9e0dd9a into containers:main Apr 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants