Skip to content
This repository has been archived by the owner on Feb 10, 2021. It is now read-only.

Publish sdist tarballs on pypi #32

Closed
toabctl opened this issue Jun 27, 2019 · 15 comments
Closed

Publish sdist tarballs on pypi #32

toabctl opened this issue Jun 27, 2019 · 15 comments

Comments

@toabctl
Copy link

toabctl commented Jun 27, 2019

Currently only wheels are published on pypi (see https://pypi.org/project/podman/#files ).
But distros might want to build from an sdist tarball so please publish that in addition to the current .whl file.

@rhatdan
Copy link
Member

rhatdan commented Jun 27, 2019

Could you open a PR to make this happen?

@toabctl
Copy link
Author

toabctl commented Jun 28, 2019

Could you open a PR to make this happen?

@rhatdan what's the process publishing on pypi? I don't find anything automated in this repo. So I assume you did that manually (with twine or so?)?
It's possible to automatically publish via travis (see https://docs.travis-ci.com/user/deployment/pypi/) but looks like you are not using travis yet.
So what's the way going forward?

@rhatdan
Copy link
Member

rhatdan commented Jun 28, 2019

I don't know, I am hoping others explain it, since I am in the dark for the entire process.
@saschagrunert @cevich @jwhonce @vrothberg @baude Any ideas?

@rhatdan
Copy link
Member

rhatdan commented Jun 28, 2019

@jnovy is this something you could help with?

@saschagrunert
Copy link
Member

saschagrunert commented Jun 28, 2019

It looks like that the package gets automatically deployed on tags:

deploy:
- provider: pypi
user: containers-libpod
password:
secure: "C88DmalsYjwtUrjWWyEeeKtLa9Q0VXlCCoCDguNOhZFmroW3DsOxZZmHBEEK3fN2QCfE5asR4zMNMpszqg324ubY6gmfy+PHVOnsLVZf4B2ZV96vhGrElk99YfgblYidwqB0L84AxK6n54iX5KFQj/8WWfkTqnPrGcA6pGX5C332uKpQoW40k/OCSbdD0C/FzaTLvgH+rUxAhamu2I2k/qJFUr6uQ5flgIJyQJcgVCvN0dP4Yyx9eSRpuWbApn0NkHOSmXJD3I2YWEf5LCSjTiyDGuQlja2rOgLynoSgBa1t8ZFXSb/nenSunAAy2y1KOcrn7qCfc56V7NwcQ+RIXT7LlSU/e2GgwHlXXsRCpZOrBcKJu3tTlVsrxpk5aXg1+boKwl2T4NEjJERskmENT2TJyZFJMr3/XAdHtnuKZcqydO/CPIqIbfRfDSN2+/8J++I1zQa5+lDXjiA/Qs7gzCW2DLZIzvzT3bD1zQPWDAP2pmixLDOY6e29jMW5pqnJazU+mrJSwOKN6e5pe5dAKx436XFByK7HZhptmkFbP5LL0HnDO6VjK4QyF1KYnBV/S4Y58FyO2jOgXA7feYaybzzbzjRbooKiqG+GC0J76GSu7dd/pqTRWVYTEn37B+No7v5HEzTP1dnQWPPynppwyBMrtT1tqsRGyEmJnm7Ml/8="
on:
tags: true
distributions: sdist bdist_wheel

@rhatdan
Copy link
Member

rhatdan commented Jun 28, 2019

So create a new tag and we are golden.

@rhatdan
Copy link
Member

rhatdan commented Jun 28, 2019

I tagged and released v0.0.1 version of this, hopefully this triggers a push to pypy so people can use it.

@rhatdan
Copy link
Member

rhatdan commented Jun 28, 2019

@saschagrunert Failed to deploy.
https://travis-ci.org/containers/python-podman/jobs/551830753
@jwhonce Any ideas?

@toabctl
Copy link
Author

toabctl commented Jul 1, 2019

I tagged and released v0.0.1 version of this, hopefully this triggers a push to pypy so people can use it.

eh - pypi has already version 0.11.1.1 . So tagging 0.0.1 seem to be wrong.

@toabctl
Copy link
Author

toabctl commented Jul 1, 2019

I guess switching to pbr or setuptools_scm makes sense here.

@4383
Copy link
Collaborator

4383 commented Jul 1, 2019

I tagged and released v0.0.1 version of this, hopefully this triggers a push to pypy so people can use it.

eh - pypi has already version 0.11.1.1 . So tagging 0.0.1 seem to be wrong.

I guess switching to pbr or setuptools_scm makes sense here.

Hey,

@toabctl: I'm not sure to see the gain to switch from pbr to setuptools_scm here, why?

The issue here is that something went wrong in the README.md and pypi try to convert it to the rst format and fail... I've submit a fix #37 to reintroduce the long_description_content_type config.

travis trigger deployments on pypi when we push a new git tag, pbr is used to generate the version automatically based on the pushed git tag. pbr is not an issue here, tagging to 0.0.1 is not an issue too, you can create new version inferior to an existing and already published version (cf. the openstack releases https://github.com/openstack/releases/commits/master).

https://travis-ci.org/containers/python-podman/jobs/551905955

@4383
Copy link
Collaborator

4383 commented Jul 1, 2019

openstack have the same issue:

http://lists.openstack.org/pipermail/openstack-discuss/2019-July/007459.html

I don't think that this is a podman issue...

@4383
Copy link
Collaborator

4383 commented Jul 1, 2019

Could you open a PR to make this happen?

@rhatdan what's the process publishing on pypi? I don't find anything automated in this repo. So I assume you did that manually (with twine or so?)?
It's possible to automatically publish via travis (see https://docs.travis-ci.com/user/deployment/pypi/) but looks like you are not using travis yet.
So what's the way going forward?

To be more clear on this topic it's already automated by using pbr and deploy on travis.

Also we already trying to publish sdist on pypi by using some travis deployment options.

The main issue for the moment is the issue related to the rst format, but it's not a podman issue, we also have the same issue on openstack... (cf. my previous comment)

@jwhonce
Copy link
Member

jwhonce commented Jul 9, 2019

@toabctl

eh - pypi has already version 0.11.1.1 . So tagging 0.0.1 seem to be wrong.

We're discussing right now should the python-podman versions track with libpod, or should the python-podman versions remain a unique vector? The source files are now being uploaded as of version 0.0.3

@jwhonce jwhonce closed this as completed Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants