Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hard code registry port #189

Closed
aweiteka opened this issue Sep 6, 2016 · 3 comments
Closed

Do not hard code registry port #189

aweiteka opened this issue Sep 6, 2016 · 3 comments
Assignees
Labels
kind/bug A defect in an existing functionality (or a PR fixing it) locked - please file new issue/PR

Comments

@aweiteka
Copy link
Contributor

aweiteka commented Sep 6, 2016

As a registry admin I am able to configure the registry to serve on any port. When using a port other than 5000 I get this error:

    "Invalid format of docker reference: expecting port 5000"

See https://github.com/projectatomic/skopeo/blob/4421e7ea2face14ce4530ed6e6df66b6f94d544f/vendor/github.com/containers/image/openshift/openshift.go#L164

Could we discover the port using ~/.docker/config.json?

@runcom runcom added the kind/bug A defect in an existing functionality (or a PR fixing it) label Sep 6, 2016
@mtrmac
Copy link
Contributor

mtrmac commented Sep 6, 2016

Philosophically, no, config.json could contain different registries for the same host, differentiated by a port.

Really what we need here is a way to get the official endpoint from the OpenShift API server, as https://github.com/projectatomic/skopeo/blob/4421e7ea2face14ce4530ed6e6df66b6f94d544f/vendor/github.com/containers/image/openshift/openshift.go#L164 says. Is that still not possible?

@mtrmac
Copy link
Contributor

mtrmac commented Sep 6, 2016

Philosophically, no, config.json

(Of course this means “in practice, yes”, but I’d much prefer a real solution to this, ingenious but ultimately risky and ugly workaround. Especially if the hostname ends up being one of the few public IPs of a cluster, this could easily collide with someone’s private registry exposed on the same IP address, couldn’t it?)

@aweiteka
Copy link
Contributor Author

aweiteka commented Sep 6, 2016

Really what we need here is a way to get the official endpoint from the OpenShift API server ... Is that still not possible?

Sadly, no. See openshift/origin#2162

Especially if the hostname ends up being one of the few public IPs of a cluster, this could easily collide with someone’s private registry exposed on the same IP address, couldn’t it?

Yes. Good point.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug A defect in an existing functionality (or a PR fixing it) locked - please file new issue/PR
Projects
None yet
Development

No branches or pull requests

3 participants