Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI VM Images #1773

Closed
wants to merge 2 commits into from
Closed

Update CI VM Images #1773

wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 12, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
containers/automation_images major 20231116t174419z-f39f38d13 -> 20231208t193858z-f39f38d13

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Dec 12, 2023
@renovate renovate bot requested a review from cevich December 12, 2023 16:07
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beta indicator needs to go away:

FEDORA_NAME: "fedora-39β"

Signed-off-by: Chris Evich <cevich@redhat.com>
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, this should be ready now.

Copy link
Contributor

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, renovate[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cevich
Copy link
Member

cevich commented Dec 13, 2023

Oh!

make[1]: Leaving directory '/go/src/github.com/containers/storage/tests/tools'
tests/tools/build/golangci-lint run --build-tags=" libdm_no_deferred_remove  "
../../../../../usr/local/go/src/net/http/internal/chunked.go:79:14: undefined: max (typecheck)
	cr.excess = max(cr.excess, 0)
	            ^
make: *** [Makefile:83: lint] Error 1

@vrothberg hit this or something very similar in a couple of other PRs: 156 and 157

@renovate renovate bot force-pushed the renovate/major-ci-vm-image branch from fdfaf97 to 0db156c Compare December 13, 2023 16:15
@cevich
Copy link
Member

cevich commented Dec 13, 2023

Argh! What's up with Renovate ignore it's own "Updates to this PR are blocked b/c you pushed a change" message, and force-push it's own update. Something is badly broken 😢

Edit: Possibly related discussion.

@cevich
Copy link
Member

cevich commented Dec 13, 2023

Renovate docs on this topic mention renaming the PR, giving that a try to stop the force-push madness.

@cevich cevich changed the title chore(deps): update dependency containers/automation_images to v20231208 Update CI VM Images Dec 13, 2023
Copy link
Contributor Author

renovate bot commented Dec 13, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@rhatdan rhatdan closed this Dec 13, 2023
@cevich
Copy link
Member

cevich commented Dec 14, 2023

@rhatdan why close, was that an accident or on purpose?

@rhatdan
Copy link
Member

rhatdan commented Dec 15, 2023

I think this was handled in a separate PR, reopen if I am mistaken.

@cevich
Copy link
Member

cevich commented Jan 9, 2024

I see now, it was in #1777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants