Skip to content

Commit

Permalink
playbooks: Require GCC and show its version
Browse files Browse the repository at this point in the history
Building Toolbx requires a C compiler [1], which defaults to GCC on
Fedora and CentOS Stream.  It's good to explicitly require it, so that
it doesn't go missing from the build.

Showing the version of the C compiler is a big help when debugging weird
build problems involving the toolchain.  A following commit will use CGO
to link to libsubid.so, which will only increase the relevance of the C
compiler.

[1] Commit c8aaed5
    containers#923

containers#1218
  • Loading branch information
debarshiray committed Jan 27, 2023
1 parent b368ccf commit e3b4b5e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion playbooks/dependencies-centos-9-stream.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
name:
- bash-completion
- flatpak-session-helper
- gcc
- golang
- httpd-tools
- meson
Expand Down Expand Up @@ -50,7 +51,7 @@
chdir: '{{ zuul.project.src_dir }}'

- name: Check versions of crucial packages
command: rpm -qa ShellCheck codespell *kernel* *glibc* golang podman conmon containernetworking-plugins containers-common container-selinux crun fuse-overlayfs flatpak-session-helper
command: rpm -qa ShellCheck codespell *kernel* gcc *glibc* golang podman conmon containernetworking-plugins containers-common container-selinux crun fuse-overlayfs flatpak-session-helper

- name: Show podman versions
command: podman version
Expand Down
3 changes: 2 additions & 1 deletion playbooks/dependencies-fedora.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
- codespell
- fish
- flatpak-session-helper
- gcc
- golang
- golang-github-cpuguy83-md2man
- httpd-tools
Expand All @@ -50,7 +51,7 @@
chdir: '{{ zuul.project.src_dir }}'

- name: Check versions of crucial packages
command: rpm -qa ShellCheck codespell *kernel* *glibc* golang podman conmon containernetworking-plugins containers-common container-selinux crun fuse-overlayfs flatpak-session-helper
command: rpm -qa ShellCheck codespell *kernel* gcc *glibc* golang podman conmon containernetworking-plugins containers-common container-selinux crun fuse-overlayfs flatpak-session-helper

- name: Show podman versions
command: podman version
Expand Down

0 comments on commit e3b4b5e

Please sign in to comment.