-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) add support for musl
using cross-rs
#2536
Conversation
c5f26a5
to
ebc2ee4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2536 +/- ##
==========================================
+ Coverage 65.86% 65.88% +0.02%
==========================================
Files 133 133
Lines 16795 16819 +24
==========================================
+ Hits 11062 11082 +20
- Misses 5733 5737 +4 |
918640b
to
01a84bb
Compare
Sorry, I won't be able to find the time this week, so I'll look at it in a few days 🙏 |
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Co-Authored-By: adrianalin <pop.adrian61@gmail.com> Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Reabsed. An example release generated by this PR is: |
Self-reminder : need to update merge CI requirements to correct CI names after this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask a favor of the documentation for developers in another PR?
https://containers.github.io/youki/developer/introduction.html
Thanks!! @jprendes |
Done ✅ |
Thanks @utam0k 💜 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops sorry I'll merge it |
Sorry, I could not find where documentation was updated (related to musl build), @jprendes please provide link. Thank you! |
I still need to create a PR. I'll do that as soon as I have some bandwidth again. |
This PR adds support for building and testing against
musl
targets.A summary of changes:
Cross.toml
and the correspondingDockerfile.musl
Dockerfile.gnu
so that we can run tests using cross.cargo.sh
script that wrapscargo
calls, using eithercargo
orcross
based on the target.mock.rs
so that it builds withmusl
targetscargo.sh
script in thefeatures_test.sh
andjustfile
musl_test.sh
.cross
, usecargo.sh
, and force usingcross
for all targets (including host target).musl
binaries as well asgnu
binaries.Example of a release generated from this PR: https://github.com/jprendes/youki/releases/tag/v0.4.1
Note: This PR builds on top of #2541. I will rebase once that is merged.