-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add serde_support to caps #151
Conversation
2612859
to
121b550
Compare
Cargo.toml
Outdated
@@ -13,7 +13,7 @@ features = ["std", "suggestions", "derive"] | |||
[dependencies] | |||
nix = "0.19.1" | |||
procfs = "0.9.1" | |||
caps = "0.5.1" | |||
caps = { git = "https://github.com/lucab/caps-rs", features = ["serde_support"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a rev
or tag
and comment that you are waiting for caps to be released?
oci_spec/Cargo.toml
Outdated
@@ -12,5 +12,5 @@ serde = { version = "1.0", features = ["derive"] } | |||
nix = "0.19.1" | |||
anyhow = "1.0" | |||
serde_json = "1.0" | |||
caps = "0.5.1" | |||
caps = { git = "https://github.com/lucab/caps-rs", features = ["serde_support"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a rev or tag and comment that you are waiting for caps to be released?
2c231fb
to
709f0b5
Compare
format cargo comments comment cargo files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
I added serde_support upstream to the caps-rs dependency. This allows us to remove the LinuxCapabilityType and use caps::Capability directly which now implements Serialize Deserialize traits.