add serde_support to caps #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrell-code
force-pushed
the
caps-serde
branch
2 times, most recently
from
2612859
to
121b550
Compare
utam0k
requested changes
Jul 21, 2021
Cargo.toml
Outdated
| @@ -13,7 +13,7 @@ features = ["std", "suggestions", "derive"] | |||
| [dependencies] | |||
| nix = "0.19.1" | |||
| procfs = "0.9.1" | |||
| caps = "0.5.1" | |||
| caps = { git = "https://github.com/lucab/caps-rs", features = ["serde_support"] } | |||
There was a problem hiding this comment.
Can you add a rev or tag and comment that you are waiting for caps to be released?
oci_spec/Cargo.toml
Outdated
| @@ -12,5 +12,5 @@ serde = { version = "1.0", features = ["derive"] } | |||
| nix = "0.19.1" | |||
| anyhow = "1.0" | |||
| serde_json = "1.0" | |||
| caps = "0.5.1" | |||
| caps = { git = "https://github.com/lucab/caps-rs", features = ["serde_support"] } | |||
There was a problem hiding this comment.
Can you add a rev or tag and comment that you are waiting for caps to be released?
ferrell-code
force-pushed
the
caps-serde
branch
2 times, most recently
from
2c231fb
to
709f0b5
Compare
format cargo comments comment cargo files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added serde_support upstream to the caps-rs dependency. This allows us to remove the LinuxCapabilityType and use caps::Capability directly which now implements Serialize Deserialize traits.