Forbid empty string values for container id in commands #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently container_id is a required argument for all commands that require container_id, but there is no restriction that empty string value cannot be provided as container_id. For example :
gives error, but
youki --root (root_path) create --bundle (bundle path) ""
does not, as (at least bash) passes "" as an empty string argument, and clap allows it, as it is a valid string value.
This PR adds forbid_empty_value to all container_id fields, which forces it to give an error message whenever empty string is provided.