Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_make_parent_mount_private #472

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

tsturzl
Copy link
Collaborator

@tsturzl tsturzl commented Nov 13, 2021

This fixes #471

The checks have just been broken out to their individual pieces rather than testing the entire comparison of the MountArgs so we can test for / or /tmp set as target, the reasoning for this is outlined in the issue.

@codecov-commenter
Copy link

Codecov Report

Merging #472 (f1c662b) into main (8cc892a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   60.46%   60.46%   -0.01%     
==========================================
  Files          82       82              
  Lines       12150    12148       -2     
==========================================
- Hits         7347     7345       -2     
  Misses       4803     4803              

@tsturzl tsturzl added the bug label Nov 13, 2021
Copy link
Collaborator

@tommady tommady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇🏻

@tommady tommady merged commit afe4921 into youki-dev:main Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_make_parent_mount_private is finding corrent parent mount of when /tmp is mounted by tmpfs
3 participants