Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin nightly version in CI as temporary fix to coverage issue #619

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Jan 17, 2022

This PR pins the version of nightly in the CI to fix the error in the CI coverage job, which is occurring. I had opened taiki-e/cargo-llvm-cov#128 where it linked to an closed issue in upstream rust repo, where it is explained that due to some changes in nightly there is some error in generating llvm coverage information.

The current fix is to pin the nightly version to a working version in CI until the nightly version is compatible again.

@codecov-commenter
Copy link

Codecov Report

Merging #619 (bfe59e4) into main (8db02e5) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   70.09%   70.07%   -0.02%     
==========================================
  Files          82       82              
  Lines       10924    10924              
==========================================
- Hits         7657     7655       -2     
- Misses       3267     3269       +2     

@YJDoc2 YJDoc2 requested a review from utam0k January 17, 2022 06:25
@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Jan 17, 2022

@utam0k PTAL
If this is ok, and merged, other PRs would need to pull and merge the main, which should trigger a re-run, and fix the coverage ; the dependabot PRs should auto-pull and fix themselves.

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utam0k utam0k merged commit 4b9cd32 into youki-dev:main Jan 17, 2022
@YJDoc2 YJDoc2 deleted the pin-ci-nightly branch October 7, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants