Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard filter #1437

Merged
merged 3 commits into from
Apr 24, 2017
Merged

Dashboard filter #1437

merged 3 commits into from
Apr 24, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Apr 14, 2017

In the dashboard, add a backends and frontends filter.

@ldez ldez added the WIP label Apr 14, 2017
@ldez ldez force-pushed the feat/backends-filter branch 2 times, most recently from e815e38 to fc97561 Compare April 14, 2017 09:28
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Go code LGTM 😍
On JS code, SGTM 😝 (my level of js/angular/… is pretty low 😂)

@ldez ldez added area/webui and removed WIP labels Apr 19, 2017
@ldez ldez changed the title Backends filter Dashboard filter Apr 19, 2017
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ldez !
Welcome back ;)
If you could also update https://github.com/containous/traefik/blob/master/docs/img/web.frontend.png, that would be awesome :)
LGTM!

@ldez
Copy link
Contributor Author

ldez commented Apr 19, 2017

Done!

@vdemeester
Copy link
Contributor

@ldez needs a rebase 🙇

@ldez ldez changed the title Dashboard filter feat(webui): Dashboard filter Apr 22, 2017
@SantoDE
Copy link
Collaborator

SantoDE commented Apr 24, 2017

😍 😍 😍 Awesome stuff!

LGTM 👼 (squash and rebase please! :D)

- Convert Object properties to and array for backends and frondends for each providers.
- Remove unused parameters.
- Add filter.
- remove dead code
- replace Fprintf by Fprint.
- update web ui dev documentation
- update Dashboard screenshot.
@vdemeester vdemeester merged commit 6012a0f into traefik:master Apr 24, 2017
@ldez ldez deleted the feat/backends-filter branch April 24, 2017 09:17
@ldez ldez added this to the 1.3 milestone Apr 24, 2017
@ldez ldez added this to the 1.3 milestone Apr 24, 2017
@ldez ldez added the kind/enhancement a new or improved feature. label Apr 29, 2017
@ldez ldez changed the title feat(webui): Dashboard filter Dashboard filter May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/webui kind/enhancement a new or improved feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants