Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge v1.4.0-rc4 into master #2202

Merged
merged 15 commits into from
Oct 2, 2017
Merged

Merge v1.4.0-rc4 into master #2202

merged 15 commits into from
Oct 2, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Oct 2, 2017

Description

Merge v1.4.0-rc4 into master

@ldez ldez added bot/light-review decreases the number of required LGTM from 3 to 1. bot/merge-method-ff status/2-needs-review labels Oct 2, 2017
@ldez ldez added this to the 1.5 milestone Oct 2, 2017
@ldez ldez requested review from a team as code owners October 2, 2017 15:21
nmengin
nmengin approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilevauge
emilevauge approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. bot/merge-method-ff status/3-needs-merge labels Oct 2, 2017
@traefiker traefiker merged commit cf508b6 into traefik:master Oct 2, 2017
@ldez ldez deleted the mrg-current-v1.4 branch October 2, 2017 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traefiker traefiker traefiker approved these changes

@nmengin nmengin nmengin approved these changes

@emilevauge emilevauge emilevauge approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.