Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems about duplicated and missing Docker backends/frontends. #2434

Merged
merged 2 commits into from
Nov 20, 2017
Merged

Fix problems about duplicated and missing Docker backends/frontends. #2434

merged 2 commits into from
Nov 20, 2017

Conversation

nmengin
Copy link
Contributor

@nmengin nmengin commented Nov 20, 2017 •
edited
Loading

What does this PR do?

The PR fixes two problems with Docker backends :

  • When swarm services has replicas, Træfik has to create only one frontend by checking if a Swarm service frontend already exists.
  • When swarm services are set with the same Træfik configuration, Træfik has to create all the frontends and backends for all the services : a new prefix with the container serviceName is added to the backend names.

Motivation

Fixes #2410

@nmengin nmengin requested a review from a team as a code owner November 20, 2017 13:37
@traefiker traefiker added this to the 1.4 milestone Nov 20, 2017
@nmengin nmengin added the kind/bug/fix a bug fix label Nov 20, 2017
ldez
ldez approved these changes Nov 20, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Nov 20, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes Nov 20, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@traefiker traefiker force-pushed the hotfix/unique-frontend-for-replicas branch from f7543fc to 6bffdbd Compare November 20, 2017 14:04
@traefiker traefiker merged commit 6619a78 into traefik:v1.4 Nov 20, 2017
@traefiker traefiker mentioned this pull request Nov 20, 2017
Closed
@mmatur mmatur mentioned this pull request Dec 29, 2017
Closed
@nmengin nmengin deleted the hotfix/unique-frontend-for-replicas branch August 3, 2018 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@nmengin @vdemeester @mmatur @ldez @traefiker