Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete maintainers processes #3681

Merged
merged 4 commits into from
Jul 27, 2018
Merged

Complete maintainers processes #3681

merged 4 commits into from
Jul 27, 2018

Conversation

emilevauge
Copy link
Member

What does this PR do?

This PR adds a Contributions Daily Meeting section and few rules in the PR review process section.

Motivation

Maintainers processes should be more detailed.

More

  • Added/updated documentation

WDYT @containous/traefik?
Anything to add/change?

@emilevauge
Complete maintainers processes
2e70c05 
This PR adds `Daily Contributions Meeting` section and few rules in the `PR review process` section
@emilevauge emilevauge added kind/enhancement a new or improved feature. area/documentation labels Jul 26, 2018
@emilevauge emilevauge mentioned this pull request Jul 26, 2018
Closed
1 task
mmatur
mmatur approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I start by not respecting the new rules but I accept them 😄

@emilevauge
Fix wording on peer's LGTM
6739a0b 
Signed-off-by: Emile Vauge <emile@vauge.com>
@emilevauge
Add issues assignment process
5d25e11 
Signed-off-by: Emile Vauge <emile@vauge.com>
@emilevauge
Add issue filter
7af27e2 
Signed-off-by: Emile Vauge <emile@vauge.com>
vdemeester
vdemeester approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@jbdoumenjou
Copy link
Member

I agree 👍

dtomcej
dtomcej approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@dtomcej dtomcej added this to the 1.7 milestone Jul 27, 2018
@traefiker traefiker merged commit 4b480ec into traefik:master Jul 27, 2018
@dtomcej dtomcej modified the milestones: 1.7, next Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@mmatur mmatur mmatur approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@emilevauge @jbdoumenjou @vdemeester @mmatur @dtomcej @traefiker