Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates Compress from bool to struct #3714

Merged
merged 2 commits into from
Aug 2, 2018
Merged

Migrates Compress from bool to struct #3714

merged 2 commits into from
Aug 2, 2018

Conversation

jbdoumenjou
Copy link
Member

What does this PR do?

Migrate Compress from bool to struct.

Motivation

To be able to manage evolutions. For example #2124

More

  • Added/updated tests
  • Added/updated documentation

jbdoumenjou and others added 2 commits August 2, 2018 14:38
@jbdoumenjou @juliens
Set Compress as a struct
c36337c 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens
Update the documentation
cd59a21 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou jbdoumenjou added this to the next milestone Aug 2, 2018
@jbdoumenjou jbdoumenjou changed the title Feature/compress Migrate Compress from bool to struct Aug 2, 2018
ldez
ldez approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

juliens
juliens approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit c159e31 into traefik:master Aug 2, 2018
@jbdoumenjou jbdoumenjou deleted the feature/compress branch November 21, 2018 08:44
@ldez ldez changed the title Migrate Compress from bool to struct Migrates Compress from bool to struct Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/middleware kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jbdoumenjou @juliens @ldez @dtomcej @traefiker