Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to official docker image v24 #107

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Switch to official docker image v24 #107

merged 1 commit into from
Aug 18, 2023

Conversation

djmaze
Copy link
Collaborator

@djmaze djmaze commented Jul 24, 2023

Unfortunately, this means losing armhf support for now. (I currently don't have the time to maintain the custom docker-in-docker armhf image anymore.)

fixes #105

@djmaze djmaze added this to the 1.8.0 milestone Jul 24, 2023
@jovobe
Copy link
Contributor

jovobe commented Aug 4, 2023

I would love to approve this, but sadly, I don't have write access.

@djmaze
Copy link
Collaborator Author

djmaze commented Aug 4, 2023

@containrrr/shepherd-contributors Can anyone else review / approve this?

@jovobe
Copy link
Contributor

jovobe commented Aug 17, 2023

@containrrr/shepherd-contributors Can anyone else review / approve this?

@djmaze I think your mention here did not work. Is there any chance this will be merged soon?

@moschlar
Copy link
Collaborator

Sorry - had been quite busy lately.

LGTM - it is indeed sad loosing armhf support, but since this is basically a "fault" by docker upstream, I think we don't need to jump through hoops enabling it.

@moschlar moschlar merged commit 5daf53b into master Aug 18, 2023
2 checks passed
@jovobe
Copy link
Contributor

jovobe commented Aug 20, 2023

@moschlar thanks for your approval 👌🏻

@djmaze when do you plan to make a new release containing this?

@moschlar
Copy link
Collaborator

In #101, we are discussing future DockerHub organisation.

@jovobe
Copy link
Contributor

jovobe commented Aug 23, 2023

@moschlar thanks for the hint! I didn't know that you're in this kind of transition phase. If I can help, just let me know 🙂

@djmaze djmaze deleted the docker_24 branch August 23, 2023 23:02
@djmaze
Copy link
Collaborator Author

djmaze commented Aug 23, 2023

@djmaze when do you plan to make a new release containing this?

Might take few days. Am currently busy with other stuff.

@GeorgesAlkhouri
Copy link

It would be great if this PR could be released. However, I totally understand that you guys have other priorities. Thanks for all the work!

@Toudahl
Copy link

Toudahl commented Sep 11, 2023

Im looking forward to this being released. Good work guys

@moschlar moschlar mentioned this pull request Sep 29, 2023
moschlar added a commit that referenced this pull request Oct 30, 2023
[Full Changelog](0.7.0...1.8.0)

**Breaking changes:**

- The docker image registry location has been changed to the containrrr organisation:
  `containrrr/shepherd`

**Implemented enhancements:**

- armhf support [\#108](#108)
- Switch to official docker image v24 [\#107](#107) ([djmaze](https://github.com/djmaze))
- Restrict runtime of "docker service update" using "timeout" [\#98](#98) ([fooflington](https://github.com/fooflington))
- Add example for usage with swarm-cronjob [\#89](#89) ([djmaze](https://github.com/djmaze))

**Fixed bugs:**

- Can't update some services: no such manifest [\#105](#105)
- Service gets stuck when calling "docker service update" and won't progress [\#97](#97)
- fix: docker service update with `--detach=false` hangs on services wi… [\#104](#104) ([AliRezaBeitari](https://github.com/AliRezaBeitari))
- Fix defunc VERBOSE handling [\#91](#91) ([sebthom](https://github.com/sebthom))

**Closed issues:**

- How does it determine if there is an update or not? [\#111](#111)
- Looking for a new maintainer [\#96](#96)
- New OCI manifest issue [\#92](#92)
- Run service update at a fixed time [\#88](#88)
- docker swarm 20.10.12 | "docker service update" requires exactly 1 argument. [\#83](#83)
- Error updating service, does not exist or it is not available when using a duplicate registry [\#78](#78)

**Merged pull requests:**

- Add apprise type and additional error notification [\#118](#118) ([andyloree](https://github.com/andyloree))
- Rename image in docs [\#114](#114) ([moschlar](https://github.com/moschlar))
- Fix release workflow [\#113](#113) ([moschlar](https://github.com/moschlar))
- Update README.md [\#103](#103) ([andrew-dixon](https://github.com/andrew-dixon))
- ci: add basic github actions for build/release [\#101](#101) ([piksel](https://github.com/piksel))
- correct misleading description of WITH\_NO\_RESOLVE\_IMAGE [\#100](#100) ([alex-vg](https://github.com/alex-vg))
- Move example configs to their own folder [\#99](#99) ([djmaze](https://github.com/djmaze))
- Add documentation about `REGISTRIES_FILE` [\#94](#94) ([tito](https://github.com/tito))
- Minor refactoring [\#90](#90) ([sebthom](https://github.com/sebthom))

Closes: #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't update some services: no such manifest
8 participants