Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release workflow #113

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Fix release workflow #113

merged 1 commit into from
Oct 7, 2023

Conversation

moschlar
Copy link
Collaborator

@moschlar moschlar commented Oct 5, 2023 •
edited
Loading

  • Use current actions release versions
  • Add cosign verify action
  • Add pushing to DockerHub

@moschlar moschlar changed the title Update release.yml Fix release action Oct 5, 2023
@moschlar moschlar requested review from piksel, djmaze and a team October 5, 2023 08:20
@moschlar moschlar mentioned this pull request Oct 5, 2023
Closed
@moschlar moschlar added this to the 1.8.0 milestone Oct 5, 2023
martadinata666
martadinata666 reviewed Oct 5, 2023
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@moschlar moschlar requested review from martadinata666 and a team October 5, 2023 09:18
martadinata666
martadinata666 approved these changes Oct 5, 2023
View reviewed changes
Copy link

@martadinata666 martadinata666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some actions version not the last release, maybe making actions spits deprecate notice. But we will see.

https://github.com/sigstore/cosign-installer 3.1.2
https://github.com/docker/login-action 3.0.0
https://github.com/docker/setup-buildx-action 3.0.0
https://github.com/docker/metadata-action 5.0.0

@moschlar moschlar removed the request for review from djmaze October 5, 2023 18:04
@moschlar
Copy link
Collaborator Author

moschlar commented Oct 6, 2023

Some actions version not the last release, maybe making actions spits deprecate notice. But we will see.

Updated those!

@moschlar moschlar force-pushed the fix-actions-release branch 3 times, most recently from 072a141 to cd4901b Compare October 6, 2023 09:52
@moschlar
Update release.yml
710962d 
- Use Actions release versions
- Use current Actions versions
- Add cosign verify action
- Add pushing to DockerHub
@moschlar moschlar changed the title Fix release action Fix release workflow Oct 6, 2023
@moschlar
Copy link
Collaborator Author

moschlar commented Oct 6, 2023

Don't know exactly how the repo permissions and review requests interwork, but apparently, @djmaze or @piksel also need to review (or just merge).

@piksel
Copy link
Member

piksel commented Oct 7, 2023

@moschlar Well, you are the maintainer, so it should be you who approves. You cannot approve your own PRs on github though, so you should just be able to check the "Merge without waiting for requirements". If you can't, I'll have to look into the requirements and lessen them a bit.

@moschlar moschlar merged commit ef6790e into master Oct 7, 2023
5 checks passed
moschlar added a commit that referenced this pull request Oct 30, 2023
@moschlar
Release new major version 1.8.0
01d070a 
[Full Changelog](0.7.0...1.8.0)

**Breaking changes:**

- The docker image registry location has been changed to the containrrr organisation:
  `containrrr/shepherd`

**Implemented enhancements:**

- armhf support [\#108](#108)
- Switch to official docker image v24 [\#107](#107) ([djmaze](https://github.com/djmaze))
- Restrict runtime of "docker service update" using "timeout" [\#98](#98) ([fooflington](https://github.com/fooflington))
- Add example for usage with swarm-cronjob [\#89](#89) ([djmaze](https://github.com/djmaze))

**Fixed bugs:**

- Can't update some services: no such manifest [\#105](#105)
- Service gets stuck when calling "docker service update" and won't progress [\#97](#97)
- fix: docker service update with `--detach=false` hangs on services wi… [\#104](#104) ([AliRezaBeitari](https://github.com/AliRezaBeitari))
- Fix defunc VERBOSE handling [\#91](#91) ([sebthom](https://github.com/sebthom))

**Closed issues:**

- How does it determine if there is an update or not? [\#111](#111)
- Looking for a new maintainer [\#96](#96)
- New OCI manifest issue [\#92](#92)
- Run service update at a fixed time [\#88](#88)
- docker swarm 20.10.12 | "docker service update" requires exactly 1 argument. [\#83](#83)
- Error updating service, does not exist or it is not available when using a duplicate registry [\#78](#78)

**Merged pull requests:**

- Add apprise type and additional error notification [\#118](#118) ([andyloree](https://github.com/andyloree))
- Rename image in docs [\#114](#114) ([moschlar](https://github.com/moschlar))
- Fix release workflow [\#113](#113) ([moschlar](https://github.com/moschlar))
- Update README.md [\#103](#103) ([andrew-dixon](https://github.com/andrew-dixon))
- ci: add basic github actions for build/release [\#101](#101) ([piksel](https://github.com/piksel))
- correct misleading description of WITH\_NO\_RESOLVE\_IMAGE [\#100](#100) ([alex-vg](https://github.com/alex-vg))
- Move example configs to their own folder [\#99](#99) ([djmaze](https://github.com/djmaze))
- Add documentation about `REGISTRIES_FILE` [\#94](#94) ([tito](https://github.com/tito))
- Minor refactoring [\#90](#90) ([sebthom](https://github.com/sebthom))

Closes: #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piksel piksel piksel approved these changes

@martadinata666 martadinata666 martadinata666 approved these changes

@djmaze djmaze Awaiting requested review from djmaze

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moschlar @piksel @martadinata666