Minor refactoring #90
Conversation
|
Thanks, but I don't know why we need github actions. I am striving to decentralize and my drone instance is already running the tests. |
|
The reason why I added the github action is, that it will also run in forks without requiring to create a PR first to get feedback from your drone instance. |
|
I have removed the Github action configuration, but I would ask you to reconsider adding it in light of the external contributions. |
|
Okay, that makes sense, and I don't have a good alternative on my mind currently. I also see in your fork that the action is working correctly. So I would be okay with re-adding the action. |
I added the gha job again. sorry for the delay |
|
Okay cool, thanks! |
[Full Changelog](0.7.0...1.8.0) **Breaking changes:** - The docker image registry location has been changed to the containrrr organisation: `containrrr/shepherd` **Implemented enhancements:** - armhf support [\#108](#108) - Switch to official docker image v24 [\#107](#107) ([djmaze](https://github.com/djmaze)) - Restrict runtime of "docker service update" using "timeout" [\#98](#98) ([fooflington](https://github.com/fooflington)) - Add example for usage with swarm-cronjob [\#89](#89) ([djmaze](https://github.com/djmaze)) **Fixed bugs:** - Can't update some services: no such manifest [\#105](#105) - Service gets stuck when calling "docker service update" and won't progress [\#97](#97) - fix: docker service update with `--detach=false` hangs on services wi… [\#104](#104) ([AliRezaBeitari](https://github.com/AliRezaBeitari)) - Fix defunc VERBOSE handling [\#91](#91) ([sebthom](https://github.com/sebthom)) **Closed issues:** - How does it determine if there is an update or not? [\#111](#111) - Looking for a new maintainer [\#96](#96) - New OCI manifest issue [\#92](#92) - Run service update at a fixed time [\#88](#88) - docker swarm 20.10.12 | "docker service update" requires exactly 1 argument. [\#83](#83) - Error updating service, does not exist or it is not available when using a duplicate registry [\#78](#78) **Merged pull requests:** - Add apprise type and additional error notification [\#118](#118) ([andyloree](https://github.com/andyloree)) - Rename image in docs [\#114](#114) ([moschlar](https://github.com/moschlar)) - Fix release workflow [\#113](#113) ([moschlar](https://github.com/moschlar)) - Update README.md [\#103](#103) ([andrew-dixon](https://github.com/andrew-dixon)) - ci: add basic github actions for build/release [\#101](#101) ([piksel](https://github.com/piksel)) - correct misleading description of WITH\_NO\_RESOLVE\_IMAGE [\#100](#100) ([alex-vg](https://github.com/alex-vg)) - Move example configs to their own folder [\#99](#99) ([djmaze](https://github.com/djmaze)) - Add documentation about `REGISTRIES_FILE` [\#94](#94) ([tito](https://github.com/tito)) - Minor refactoring [\#90](#90) ([sebthom](https://github.com/sebthom)) Closes: #117
This PR addresses some low hanging fruits and adds a github action that automatically runs shellcheck.