Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.x - fix iOS-touch-bug #14

Closed
zonky2 opened this issue Jun 22, 2019 · 2 comments
Closed

1.0.x - fix iOS-touch-bug #14

zonky2 opened this issue Jun 22, 2019 · 2 comments
Assignees
Labels

Comments

@zonky2
Copy link

zonky2 commented Jun 22, 2019

add role="button" at toggler to fix touch support

-  <div class="panel-heading <?php echo $this->toggler; ?>"<?php if ($this->headlineStyle): ?> style="<?php echo $this->headlineStyle; ?>"<?php endif; ?> data-toggle="collapse"<?php if($group): ?> data-parent="#<?php echo $group; ?>"<?php endif; ?> data-target="#accordion-<?php echo $this->id; ?>">
+  <div class="panel-heading <?php echo $this->toggler; ?>"<?php if ($this->headlineStyle): ?> style="<?php echo $this->headlineStyle; ?>"<?php endif; ?> data-toggle="collapse"<?php if($group): ?> data-parent="#<?php echo $group; ?>"<?php endif; ?> data-target="#accordion-<?php echo $this->id; ?>" role="button">

see ember-bootstrap/ember-bootstrap#355 (comment)

@dmolineus
Copy link
Member

According to ember-bootstrap/ember-bootstrap#355 (comment) it's the wron solution as the role of the panel-heading should be role="tab" which is added by 75608d7.

You'd should use the css solution suggested in your link.

@dmolineus dmolineus self-assigned this Jul 22, 2019
@zonky2
Copy link
Author

zonky2 commented Jul 22, 2019

maybe we add at readme "known issues" with this tip to change the CSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants