Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permission "standard" at BE sorting lost after first save #342

Closed
zonky2 opened this issue Apr 26, 2017 · 3 comments
Closed

permission "standard" at BE sorting lost after first save #342

zonky2 opened this issue Apr 26, 2017 · 3 comments
Labels
bug
Milestone
2.0.0

Comments

@zonky2
Copy link
Contributor

zonky2 commented Apr 26, 2017 •
edited
Loading

at sorting/grouping at input mask lost the permission "standard" if other configuration or new one saved...

look also #341

should implement with #321

contao-community-alliance/dc-general dev-hotfix/beta-39 (c0a5e69)
metamodels/core dev-hotfix/alpha-15 (9579ebb2)
@zonky2 zonky2 added the bug label Apr 26, 2017
@zonky2 zonky2 added this to the 2.0.0 milestone Apr 26, 2017
@zonky2 zonky2 changed the title permission "standard" at BE sorting lost after save permission "standard" at BE sorting lost after first save May 18, 2017
@zonky2
Copy link
Contributor Author

zonky2 commented May 23, 2017

@discordier
pls look at https://github.com/contao-community-alliance/dc-general/blob/master/src/ContaoCommunityAlliance/DcGeneral/Contao/Subscriber/FallbackResetSubscriber.php#L54-L55

may be should we use PrePersistModelEvent and PreDuplicateModelEvent because we should clean the table before we save the value instead after...

https://github.com/contao-community-alliance/dc-general/blob/master/src/ContaoCommunityAlliance/DcGeneral/Contao/Subscriber/FallbackResetSubscriber.php#L122-L123

zonky2 added a commit to zonky2/dc-general that referenced this issue May 23, 2017
@zonky2
Hotfix contao-community-alliance#342 set standard at sortgroup
8a40b6f
zonky2 added a commit to zonky2/dc-general that referenced this issue May 23, 2017
@zonky2
Hotfix contao-community-alliance#342 set standard at sortgroup
272f509
zonky2 added a commit to zonky2/dc-general that referenced this issue May 23, 2017
@zonky2
Hotfix contao-community-alliance#342 set standard at sortgroup
b13eeb6
@zonky2 zonky2 mentioned this issue May 23, 2017
Closed
@zonky2
Copy link
Contributor Author

zonky2 commented May 23, 2017

PR #346

@zonky2 zonky2 removed the question label May 23, 2017
discordier added a commit to MetaModels/core that referenced this issue May 30, 2017
@discordier
Force id to be string
def1cc7 
See contao-community-alliance/dc-general#342
baumannsven added a commit that referenced this issue Aug 22, 2017
@baumannsven
Merge branch 'hotfix_#342_set_standard_at_sortgroup' into hotfix/beta-40
0fd448f 
* hotfix_#342_set_standard_at_sortgroup:
  Hotfix #342 set standard at sortgroup
@zonky2
Copy link
Contributor Author

zonky2 commented Aug 22, 2017

merged in beta-40

@zonky2 zonky2 closed this as completed Aug 22, 2017
baumannsven added a commit that referenced this issue Aug 24, 2017
@baumannsven
Merge branch 'hotfix/beta-40' into feature/contao4
eda9af4 
* hotfix/beta-40:
  Hotfix #350 save alias  or combined values if readonly and force alias
  Hotfix #342 set standard at sortgroup
  Add GitHub templates (closes #304)

# Conflicts:
#	src/Controller/DefaultController.php
#	src/Data/DefaultDataProvider.php
discordier added a commit to MetaModels/core that referenced this issue Mar 6, 2018
@discordier
Force id to be string
802604b 
See contao-community-alliance/dc-general#342
discordier added a commit to MetaModels/core that referenced this issue Mar 10, 2018
@discordier
Force id to be string
f091f87 
See contao-community-alliance/dc-general#342
discordier added a commit to MetaModels/core that referenced this issue Mar 10, 2018
@discordier
Force id to be string
187e383 
See contao-community-alliance/dc-general#342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@zonky2