Hotfix/reset fallback

[discordier]

This is an attempt to solve #303 (which is duped by MetaModels/core#35).

We are now examining the parent child relationship of the data container to determine the siblings of the passed model and reset only within those.

Additionally, the method DataProviderInterface::resetFallback() has been deprecated, as it won't be possible to implement it properly without passing a config and/or making the driver stateful of which both are not good at all.

I like the approach to shift the responsibility into the reset listener much more.

Please test this implementation, I performed tests with MetaModels/core and defining render settings and input screens worked again.

[zonky2]

I have testet and works fine for

Rendersettings

Input mask

Grouping & sorting

but in which case we can use "isDefault" for rendersetting and input mask?

[zonky2]

I found a warning with

• DCG dev-hotfix/reset-fallback (5689fe7)
• MM core dev-hotfix/alpha-15 (94cf9fab)

if I open the list of attributes (attribut icon) we have the follow warning

Warning: array_merge_recursive(): Argument #2 is not an array in composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\Dca\Builder\Legacy\ExtendedLegacyDcaDataDefinitionBuilder.php on line 437

#0 [internal function]: __error(2, 'array_merge_rec...', 'C:\\Contao2Go\\ht...', 437, Array)
#1 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\Dca\Builder\Legacy\ExtendedLegacyDcaDataDefinitionBuilder.php(437): array_merge_recursive(Array, NULL)
#2 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\Dca\Builder\Legacy\ExtendedLegacyDcaDataDefinitionBuilder.php(477): ContaoCommunityAlliance\DcGeneral\Contao\Dca\Builder\Legacy\ExtendedLegacyDcaDataDefinitionBuilder->parseParentChildConditions(Object(ContaoCommunityAlliance\DcGeneral\DataDefinition\Definition\DefaultModelRelationshipDefinition))
#3 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Contao\Dca\Builder\Legacy\ExtendedLegacyDcaDataDefinitionBuilder.php(68): ContaoCommunityAlliance\DcGeneral\Contao\Dca\Builder\Legacy\ExtendedLegacyDcaDataDefinitionBuilder->parseConditions(Object(ContaoCommunityAlliance\DcGeneral\DataDefinition\DefaultContainer))
#4 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\DataDefinition\Builder\AbstractEventDrivenDataDefinitionBuilder.php(96): ContaoCommunityAlliance\DcGeneral\Contao\Dca\Builder\Legacy\ExtendedLegacyDcaDataDefinitionBuilder->build(Object(ContaoCommunityAlliance\DcGeneral\DataDefinition\DefaultContainer), Object(ContaoCommunityAlliance\DcGeneral\Factory\Event\BuildDataDefinitionEvent))
#5 [internal function]: ContaoCommunityAlliance\DcGeneral\DataDefinition\Builder\AbstractEventDrivenDataDefinitionBuilder->process(Object(ContaoCommunityAlliance\DcGeneral\Factory\Event\BuildDataDefinitionEvent), 'dc-general.fact...', Object(Symfony\Component\EventDispatcher\EventDispatcher))
#6 composer\vendor\symfony\event-dispatcher\EventDispatcher.php(184): call_user_func(Array, Object(ContaoCommunityAlliance\DcGeneral\Factory\Event\BuildDataDefinitionEvent), 'dc-general.fact...', Object(Symfony\Component\EventDispatcher\EventDispatcher))
#7 composer\vendor\symfony\event-dispatcher\EventDispatcher.php(46): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(Array, 'dc-general.fact...', Object(ContaoCommunityAlliance\DcGeneral\Factory\Event\BuildDataDefinitionEvent))
#8 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Factory\DcGeneralFactory.php(392): Symfony\Component\EventDispatcher\EventDispatcher->dispatch('dc-general.fact...', Object(ContaoCommunityAlliance\DcGeneral\Factory\Event\BuildDataDefinitionEvent))
#9 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Factory\DcGeneralFactory.php(336): ContaoCommunityAlliance\DcGeneral\Factory\DcGeneralFactory->createContainer()
#10 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\Factory\DcGeneralFactory.php(298): ContaoCommunityAlliance\DcGeneral\Factory\DcGeneralFactory->createEnvironment()
#11 composer\vendor\contao-community-alliance\dc-general\src\ContaoCommunityAlliance\DcGeneral\DC\General.php(80): ContaoCommunityAlliance\DcGeneral\Factory\DcGeneralFactory->createDcGeneral()
#12 system\modules\core\classes\Backend.php(408): ContaoCommunityAlliance\DcGeneral\DC_General->__construct('tl_metamodel_at...', Array)
#13 system\modules\core\controllers\BackendMain.php(131): Contao\Backend->getBackendModule('metamodels')
#14 contao\main.php(20): Contao\BackendMain->run()
#15 {main}

[discordier]

This does not happen on my side. I can list the attributes just fine.

[zonky2]

is fixed with #323

[zonky2]

this implementation MetaModels/core#1213 have a bug in https://github.com/contao-community-alliance/dc-general/blob/master/src/ContaoCommunityAlliance/DcGeneral/Contao/Subscriber/FallbackResetSubscriber.php#L90

this method should reset the parameter e.g. "isdefault" only if the new item is set as default (=1)

    private function handleFallback(AbstractModelAwareEvent $event)
    {
        $model        = $event->getModel();
        $dataProvider = $event->getEnvironment()->getDataProvider($model->getProviderName());
        $properties   = $event->getEnvironment()->getDataDefinition()->getPropertiesDefinition();

        foreach (array_keys($model->getPropertiesAsArray()) as $propertyName) {
            if (!$properties->hasProperty($propertyName)) {
                continue;
            }

            $extra = (array) $properties->getProperty($propertyName)->getExtra();
            if (array_key_exists('fallback', $extra) && (true === $extra['fallback'])) {
                // BC Layer - use old reset fallback methodology until it get's removed.
                if (null === ($config = $this->determineFilterConfig($event))) {
                    // @codingStandardsIgnoreStart
                    @trigger_error(
                        'DataProviderInterface::resetFallback is deprecated - ' .
                        'Please specify proper parent child relationship',
                        E_USER_DEPRECATED
                    );
                    // @codingStandardsIgnoreEnd

                    $dataProvider->resetFallback($propertyName);
                }

+                if (!$model->getProperty($propertyName)) {
+                    continue;
+                }

                $models = $dataProvider->fetchAll($config);

                foreach ($models as $resetModel) {
                    if ($model->getId() === $resetModel->getId()) {
                        continue;
                    }
                    $resetModel->setProperty($propertyName, null);
                    $dataProvider->save($resetModel);
                }
            }
        }
    }
``

[discordier]

Please open a new ticket in instead of necroposting to merged pull requests.
Please reference this PR in the ticket.

[zonky2]

done #402