Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a play button and GDPR hint to splash images #3178

Closed
leofeyer opened this issue Jul 9, 2021 · 4 comments · Fixed by #4823
Closed

Add a play button and GDPR hint to splash images #3178

leofeyer opened this issue Jul 9, 2021 · 4 comments · Fixed by #4823
Labels
Milestone

Comments

@leofeyer
Copy link
Member

leofeyer commented Jul 9, 2021

Is there a specific reason why by default there is no play icon as an overlay over splash images? From a usability point of view I don't find the current solution very user friendly. I've stumbled upon a view examples where I didn't recognize a video as such because it was "disguised" as a "regular" image. IMHO, a play icon should therefore be included as an overlay by default.

Originally posted by @madmaharaja in #300 (comment)

@leofeyer leofeyer added this to the 4.13 milestone Jul 9, 2021
@leofeyer leofeyer changed the title Add a play button and GDPR hint to the splash images Add a play button and GDPR hint to splash images Jul 9, 2021
@aschempp
Copy link
Member

FYI there have been multiple comments to that in #300, here's the initial one by @ausi which I fully agree with

I think the play icon should be part of the CSS of your website as it would most probably be styled differently by every website.

if we include something, it should be a style sheet similar to the icons CSS that you can individually select in the layout. That would not affect existing sites. But I don't really see the point for like 5 likes of CSS that 5% of websites will use 🤷

@leofeyer
Copy link
Member Author

leofeyer commented Jul 13, 2021

It does not hurt either, does it? Also, it is probably more about the text overlay (click to playyour IP address will be sent to YouTube) than the icon.

@aschempp
Copy link
Member

It does not hurt either, does it?

Not sure what you're referring to?

@kroerig
Copy link

kroerig commented Dec 29, 2021

I would prefer having a simple default play button and a hint for GDPR. Maybe the last one should be configurable in the settings because it's content may differ from platform to platform.

@leofeyer leofeyer modified the milestones: 4.13, 5.0 Jan 18, 2022
@leofeyer leofeyer linked a pull request Jul 12, 2022 that will close this issue
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants