Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Liveupdate does not fully check permission on local file system before updating #44

Closed
ghost opened this issue Nov 29, 2011 · 3 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Nov 29, 2011

Sometimes the folder permissions are changed here and there for adding other modules, updating system and config files or custom edits.

The LiveUpdate function only checks a few file/folder locations for correct write permissions. Would it be possible to check all files/folders for correct permissions before upgrading.

This will prevent downloading the 3MB file, and then when writing all the files, it fails in many places due to incorrect permissions.

Perhaps permissions checking button, to write out a report of all the problem files/folders before you start with the live update. Or perhaps a modified version of the system check, which scans the folders files in the existing TL site.

e.g. readytoupgrade.php (in the root or system)

--- Originally created by thyon on September 2nd, 2008, at 11:44am (ID 44)

@ghost ghost assigned leofeyer Nov 29, 2011
@leofeyer
Copy link
Member

Changing the permissions does not necessarily mean that the live update will not work anymore. The maintenance module does only a quick check to ensure that the Safe Mode Hack has been enabled if it is required. It is not supposed to check all files and folders.

To check all files and folders, please use the system check tool.

--- Originally created on September 2nd, 2008, at 12:02pm

@ghost
Copy link
Author

ghost commented Nov 29, 2011

I was unaware that the system check tool does this, as I only assumed it checks permissions for blank installations (before TL is installed).

--- Originally created by thyon on September 2nd, 2008, at 12:05pm

@leofeyer
Copy link
Member

--- Originally closed on September 2nd, 2008, at 12:02pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant