Add namespaced exceptions and a specific FileNotExistsException #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-vo
approved these changes
Feb 14, 2021
leofeyer
approved these changes
Feb 15, 2021
|
Should we release a new minor version 1.1.0 after merging this? |
|
I guess so, yes. |
ausi
changed the title
|
Noice! 🎉 |
leofeyer
pushed a commit
to contao/contao
that referenced
this pull request
Mar 18, 2021
Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes #1995 | Docs PR or issue | contao/docs#688 ~~Depends on contao/image#79~~ The image controller now returns a 404 status code if the deferred image json exists but the source image file is missing. The `resize-images` command now has an option `--preserve-missing` as discussed in #1995 (comment) Commits ------- 3884c4b Show 404 status if image file not exists 719c956 Add delete-missing option to resize images command df640b6 Fix backwards compatibility with contao/image 1.0 b947f11 Invert option delete-missing to preserve-missing 2e9f61f Merge branch '4.9' into fix/missing-image-resource-404 fabdbd2 CS
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this pull request
Mar 18, 2021
Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes #1995 | Docs PR or issue | contao/docs#688 ~~Depends on contao/image#79~~ The image controller now returns a 404 status code if the deferred image json exists but the source image file is missing. The `resize-images` command now has an option `--preserve-missing` as discussed in contao/contao#1995 (comment) Commits ------- 3884c4b6 Show 404 status if image file not exists 719c9567 Add delete-missing option to resize images command df640b67 Fix backwards compatibility with contao/image 1.0 b947f115 Invert option delete-missing to preserve-missing 2e9f61f4 Merge branch '4.9' into fix/missing-image-resource-404 fabdbd23 CS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a better usage of exceptions in the whole library. Now every exception that the library throws implements the
Contao\Image\Exception\ExceptionInterface.This is required in order to fix contao/contao#1995 (comment)