Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for GET published asset endpoint [] #2134

Merged
merged 1 commit into from
Jan 25, 2024
Merged

feat: add support for GET published asset endpoint [] #2134

merged 1 commit into from
Jan 25, 2024

Conversation

chrishelgert
Copy link
Contributor

@chrishelgert chrishelgert commented Jan 19, 2024 •
edited
Loading

Summary

The GET endpoint for published assets was not yet added to the client.

Motivation and Context

https://www.contentful.com/developers/docs/references/content-management-api/#/reference/assets/published-assets-collection (JavaScript)

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

When adding a new method:

  • The new method is exported through the default and plain CMA client
  • All new public types are exported from ./lib/export-types.ts
  • Added a unit test for the new method
  • Added an integration test for the new method
  • The new method is added to the documentation

@chrishelgert chrishelgert marked this pull request as ready for review January 24, 2024 12:45
@chrishelgert chrishelgert requested a review from a team as a code owner January 24, 2024 12:45
colomolo
colomolo approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@colomolo colomolo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

@chrishelgert chrishelgert merged commit 2ee1ebf into master Jan 25, 2024
2 of 3 checks passed
@chrishelgert chrishelgert deleted the feat/published-assets branch January 25, 2024 08:48
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colomolo colomolo colomolo approved these changes

@YvesRijckaert YvesRijckaert Awaiting requested review from YvesRijckaert

@aodhagan-cf aodhagan-cf Awaiting requested review from aodhagan-cf

@andipaetzold andipaetzold Awaiting requested review from andipaetzold

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrishelgert @colomolo