Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nested Locale handling #73

Closed
dlitvakb opened this issue Oct 27, 2015 · 0 comments
Closed

Fix Nested Locale handling #73

dlitvakb opened this issue Oct 27, 2015 · 0 comments
Assignees

Comments

@dlitvakb
Copy link
Contributor

Currently we have two ways of handling Locales

  1. Entry#fields accept a Locale as a parameter and returns localized versions of the resources (Sync API only) Parse nested locales in AssetFields #66
  2. Each field on an Entry has a Hash with locales upon request with locale: "*" (contentful_middleman multiple locale support, it was needed that by default each entry would have locales readily available) Add support for multiple locales on Entries #72

The second way was introduced to give support to contentful_middleman for multiple locales.

We need to standardize it so there's only one way to deal with Locales. We also need to make sure that the way we choose to not make default still works afterwards to avoid breaking production code.

The reason this is a bit tricky is because each field can be localized separately in the CDA API and we need the Content Type definition to check each field separately.

Currently the nested_locale_fields functionality works for the Sync API because every field, independently of configuration will return a Locale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant