Unify Locale Handling #78
Conversation
dlitvakb
force-pushed
the
dl/unify-locale-handling
branch
2 times, most recently
from
34c170a
to
5abb41f
Compare
| expect(cat.fields[:name][:'en-US']).to eq "Nyan Cat" | ||
| expect(cat.fields[:name][:'es']).to eq "Gato Nyan" | ||
| expect(cat.fields('en-US')[:name]).to eq "Nyan Cat" | ||
| expect(cat.fields('es')[:name]).to eq "Gato Nyan" |
There was a problem hiding this comment.
I'm not quite sure why we are reversing the order of parameters here? It'll be a breaking change.
In any case, the locale parameter should be a symbol, otherwise it'll be inconsistent with field_with_locales.
There was a problem hiding this comment.
This is actually the expected behavior of fields, I was omitting that behavior in order to be able to serialize correctly in contentful_middleman.
This, though breaking is undocumented anywhere else than this test, and is fixing the dispaired behavior.
fields_with_locales is the in place replacement for this functionality, and it is documented properly
There was a problem hiding this comment.
You're right, this is actually the documented way, at least for sync: https://github.com/contentful/contentful.rb/blame/master/README.md#L327
I still think we should make both methods consistent in their use of symbols vs. strings for the locales, otherwise it'll be confusing.
dlitvakb
force-pushed
the
dl/unify-locale-handling
branch
from
5abb41f
to
df258b3
Compare
|
|
Fixes #73