This repository has been archived by the owner on May 8, 2024. It is now read-only.
Add Localize Helpers #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlitvakb
force-pushed
the
dl/add-localize-helper
branch
2 times, most recently
from
e487d15
to
fdde1ba
Compare
|
|
||
| If your fields are not localized, the value of the field will be returned. | ||
|
|
||
| In case of the field being localized but the locale not found, it will use |
There was a problem hiding this comment.
I think we should reformulate this to
In case of the field being localized, but no value being set for a given entry, it will use…
Otherwise people might be confused what "not found" means and why it would happen.
There was a problem hiding this comment.
This has been changed
|
This PR should not yet be merged contentful/contentful.rb#73 fix will break this, working on a solution |
dlitvakb
force-pushed
the
dl/add-localize-helper
branch
from
fdde1ba
to
4ae61bd
Compare
|
Specs will be green when contentful/contentful.rb#78 is merged and released |
dlitvakb
force-pushed
the
dl/add-localize-helper
branch
from
4ae61bd
to
7f9c035
Compare
dlitvakb
force-pushed
the
dl/add-localize-helper
branch
from
7f9c035
to
509e600
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.