Add support for multiple locales on Entries #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlitvakb
force-pushed
the
dl/allow-multi-locales
branch
from
5809244 to
caa2814
Compare
dlitvakb
force-pushed
the
dl/allow-multi-locales
branch
from
caa2814 to
c9e2939
Compare
| expect(asset.file.properties[:details]['size']).to eq 522943 | ||
| expect(asset.file.properties[:details][:image]['width']).to eq 5800 | ||
| expect(asset.file.properties[:details][:image]['height']).to eq 4350 | ||
| expect(asset.file.properties[:details][:size]).to eq 522943 |
There was a problem hiding this comment.
This would be a breaking change, can we avoid that?
dlitvakb
force-pushed
the
dl/allow-multi-locales
branch
from
d815a22 to
f529ed5
Compare
|
Hey @neonichu I found what was causing the breaking change and fixed it, now everything should work 👍 |
| !self.is_a?(Asset) && | ||
| !is_location?(value) && | ||
| !is_link?(value) && | ||
| !is_image?(value) |
There was a problem hiding this comment.
Hm, can we maybe reverse the logic here? Otherwise, I could see us ending up with inconsistencies in which keys are symbols and which are strings very easily if we don't remember amending the list of opt-out cases.
There was a problem hiding this comment.
This will be address in a future cleanup of nested locale handling in general, see #73
|
@neonichu can we merge this? We need it for |
|
@dlitvakb Yes, out of GH notifications, out of mind 😞 |
neonichu
added a commit
that referenced
this pull request
Nov 2, 2015
Add support for multiple locales on Entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes contentful_middleman/#39