Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still having P-CPU issues on M2 Max #10

Closed
valeriylo opened this issue May 20, 2024 · 3 comments
Closed

Still having P-CPU issues on M2 Max #10

valeriylo opened this issue May 20, 2024 · 3 comments

Comments

@valeriylo
Copy link

valeriylo commented May 20, 2024

2024-05-20.21.47.19.mov

Latest 0.1.6, same on behaviour after brew upgrade mactop from 0.1.5 and after brew uninstall mactop && brew install mactop.
New powermetrics output is in the attached txt file
powermetrics_valeriylo.txt

@metaspartan
Copy link
Collaborator

The latest fix was only for M3 Max, looks like M2 Max needs the same patch as M3, it is a one line change in the code if you want to test yourself, will get it resolved for v0.1.7, apologies.

https://github.com/context-labs/mactop/blob/main/main.go#L592

Replace this:
if modelName == "Apple M3 Max" {

With this:
if modelName == "Apple M3 Max" || modelName == "Apple M2 Max" {

I will try to get the patch up this week. Thanks for reporting!

@metaspartan
Copy link
Collaborator

Give v0.1.7 a shot now, should work 👍

@valeriylo
Copy link
Author

Yeah, it seems to be fixed now, thanks!
Although, E-CPU & P-CPU update bar is a bit "jittery", not sure if it can be smoothed out. Looking forward new updates!

2024-05-21.08.10.20.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants