Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version string #103

Closed
nvt opened this issue Oct 19, 2017 · 5 comments
Closed

New version string #103

nvt opened this issue Oct 19, 2017 · 5 comments

Comments

@nvt
Copy link
Member

nvt commented Oct 19, 2017

At startup, the first line printed is typically the CONTIKI_VERSION_STRING value set in Makefile.include, which looks like "Contiki-3.x-3638-gc1a917a". Should we change it to "Contiki-NG-3638-g1a917a", "Contiki-NG-1.x-3638-g1a917a", or something else?

@g-oikonomou
Copy link
Member

I think we probably should. This also reminds me a comment by Michael Richardson about Contiki not having a clear version.h. Perhaps something to think about adding too, and then the Makefile can append the git version if built from within a git repo?

@nvt
Copy link
Member Author

nvt commented Oct 23, 2017

Yes, perhaps a header file that has at least clear definitions of major/minor version integers, and a git commit version can indeed be set through the Makefile when applicable. Contiki has core/contiki-version.h with only a version string definition, but this file was removed from Contiki-NG early on.

@simonduq
Copy link
Member

simonduq commented Oct 23, 2017

After a chat with @g-oikonomou and @joakimeriksson, we propose to use as version "NG-4.0" for the release.

@simonduq
Copy link
Member

I looked a bit into this. I vote for Contiki-NG-4.x-3638-g1a917a.
A question is how do we git tag master at the release? 4.x or NG-4.x? This affects how we produce the string.

@simonduq
Copy link
Member

simonduq commented Nov 1, 2017

done in #117

@simonduq simonduq closed this as completed Nov 1, 2017
pjonsson added a commit to pjonsson/contiki-ng that referenced this issue May 25, 2022
Commits:
979bf199 Merge pull request contiki-ng#111 from pjonsson/update-mspsim
5004dcdf Update mspsim submodule
5789c4ea Merge pull request contiki-ng#90 from pjonsson/stop-boxing
4996eb44 Merge pull request contiki-ng#103 from pjonsson/update-mspsim
ba66e502 Merge pull request contiki-ng#110 from pjonsson/fix-box-deprecation-warnings
177e3a1b Merge pull request contiki-ng#108 from pjonsson/mspsim-ignore-untracked
3479b27a Fix boxing deprecation warnings
3417074d Merge pull request contiki-ng#109 from pjonsson/check-java
f9c4ad8e build.xml: fail on Java < 11
8c393d7b Remove some explicit boxing
b47c4116 Merge pull request contiki-ng#106 from pjonsson/more-unused
4e7d64ef mspsim: ignore untracked changes
998b2045 Merge pull request contiki-ng#105 from pjonsson/remove-unused-imports
7a85907a Merge pull request contiki-ng#107 from pjonsson/remove-parens
a075b102 Remove superfluous parentheses
0fb692ae Remove unused variables/initalizations
a992585b Remove unused imports
eed48b1a Update mspsim submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants