Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a result visualization example with logfile analysis and plotting script #1395

Merged

Conversation

atiselsts
Copy link
Member

This adds an often requested feature - an example that shows how various metric can be obtained and plotted from log files.

Documentation is provided in the README file. If the PR is accepted, I will publish a more extensive documentation as a tutorial in the Contiki-NG wiki.

@g-oikonomou
Copy link
Member

This is VERY desirable! 🥳

@rajeev1986
Copy link

A much-needed feature. Although IoTBench consortium has been running for the past 2years, open-source scripts for analyzing and plotting data has never been released, which can lead to discrepancies in results published out there.
Very cool @atiselsts .

@atiselsts atiselsts force-pushed the feature/result-visualization-example branch from 32547d0 to ddc8597 Compare October 14, 2020 12:32
@g-oikonomou g-oikonomou added this to the Version 4.6 milestone Oct 14, 2020
@atiselsts atiselsts force-pushed the feature/result-visualization-example branch from ddc8597 to 5a4120e Compare October 19, 2020 09:32
@atiselsts atiselsts force-pushed the feature/result-visualization-example branch from 5a4120e to 26e2abd Compare October 27, 2020 14:02
@atiselsts
Copy link
Member Author

@simonduq

  1. I have changed the location to examples/benchmarks/result-visualization

  2. I looked into rpl-req-resp example and I'm not convinced they should be merged. You have a data query application, while my example has the more common data collection traffic pattern. I think there is room for both, in different .c files.

  3. I don't know about adding the examples as a regression test as it is - it takes relatively long time to execute. Alternatively, a shorter test script could be added to tests folder (just to check if the basic running+plotting functionality is working, not to get useful results - for example, just 5 minute execution in a small network). What do you think? Is it fine to just use the cooja.csc file as it is? It takes 1min 20sec to run the current example on fast CPU (10th gen i7).

@simonduq
Copy link
Member

Great! I thought we aimed for building all examples on at least one target. Generally not great to add code that isn't even built by CI.

Adding a test script sure! Even run in CI I'd say.

@atiselsts atiselsts force-pushed the feature/result-visualization-example branch from aa963be to 5b50c49 Compare October 29, 2020 18:16
@atiselsts
Copy link
Member Author

New regression test added, with its own .csc file.

@simonduq simonduq merged commit 288d330 into contiki-ng:develop Nov 3, 2020
@atiselsts atiselsts deleted the feature/result-visualization-example branch November 15, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants