BSL: Change PYTHON value to python3

[jeppenodgaard]

Should fix #1444

[g-oikonomou]

Thanks.

We are excluding #1441 from the upcoming release (but keeping it in develop), it looks like there is a little bit of work to be done in order to transition cleanly to Python 3, but it's good that we've started this already.

[jeppenodgaard]

I consider removing the $(PYTHON) ... from the BSL lines because the script uses shebang to choose the correct interpreter. Would this be a better approach?

[g-oikonomou]

So you are saying we should make the script executable and run it in itself?

[jeppenodgaard]

That is my suggestion yes. The file already seems to have executable permissions.
This allows removing the PYTHON variable and the need to maintain it.
I'm not sure if there's any cons to this approach..

[g-oikonomou]

@atiselsts how do you feel about this?

[atiselsts]

I prefer the shebang approach (just learned that is the name of the thing!). It reduces the number of times python version is referenced in the codebase and is consistent with the approach already used in older platforms (Sky and Z1).

[g-oikonomou]

OK, I too would be happy with that. @jeppenodgaard do you have time to work on it?

[jeppenodgaard]

@g-oikonomou Yes. I should be able to test it tomorrow.

[jeppenodgaard]

Ready for review