OpenMote: Fixes and Improvements #1600
Conversation
kkrentz
changed the title
kkrentz
changed the title
Makefile.include
Outdated
| @@ -498,6 +501,7 @@ viewconf: | |||
| @echo "----------------- Make variables: --------------" | |||
| @echo "##### \"TARGET\": ________________________________ $(TARGET)" | |||
| @echo "##### \"BOARD\": _________________________________ $(BOARD)" | |||
| @echo "##### \"BOARD_REVISION\": _________________________$(BOARD_REVISION)" | |||
There was a problem hiding this comment.
I don't know anything about these parts of the build system but I think there's a space missing between the underscores and the board revision.
|
I haven't read any guidelines but the formatting style in Makefiles for many platforms is pretty consistent with using two spaces for each nesting level of ifeq/ifdef. |
|
Thank you for your feedback. I adapted things accordingly. |
|
Hi! This was my mistake, very sorry about it, re-opening this PR now. What happened is the following: I was switching the base branch for this repository https://github.com/wittra/contiki-ng from develop to wittra. But accidentally, I made the change on the wrong repo (this repo) and instead of switching the base branch I renamed it. And somehow github deleted develop and closed all PRs... Many apologies for this mishap 🙏; I haven't contributed in a while.. but now at least everybody got some notification from me :p |
|
I have added an update to the cc2538-bsl tool. I realized that I always tested with a more recent version of it, which may have been the reason why my fix has not worked for everyone. Anyway, this newer version of cc2538-bsl works for both OpenMote-B and Rev.-A1 OpenMotes. |
|
Unless I'm confusing PRs: I think this PR got stuck because different batches of the hardware has two behaviors for the same revision number, so Contiki-NG behaves correctly for some hardware, and others with the same revision run into #1733.
Please make a separate PR for that, I think that should be fairly easy to get merged. |
I resembled the pin configuration of RIOT-OS and had no more issues since then. Something to watch out for is to correctly set
Opened #2806 |
|
I am not using OpenMote but the changes seem reasonable and I note at least two other people have tested/cherry-picked with at least one positive feedback that it solves the issues. The PR also fixes what seems to be a fundamental issue for the boards in #1733 so I am giving it 👍 to hopefully get it moving. @kkrentz do you mind rebasing so that we get it updated and have the CI re-run |
Usage example: make TARGET=openmote BOARD=openmote-cc2538 BOARD_REVISION=REV_A1 savetarget
This PR includes some fixes and improvements to the OpenMote platform. In particular, I fixed #1733. Flashing an OpenMote-B now works without manual intervention:
make TARGET=openmote BOARD=openmote-b savetarget make hello-world.upload && make login