Workaround for DAO having garbled content after RPL forwarding error #2545
Conversation
|
The test case is valuable to get into develop for tracking the behavior, so we'll know if this issue is accidentally fixed by something else. Can you split out the test cases to a separate PR that can be merged? Just invert the logic for passing/failing testcase, and put a FIXME in a comment above that. |
|
Hi! This was my mistake, very sorry about it, re-opening this PR now. What happened is the following: I was switching the base branch for this repository https://github.com/wittra/contiki-ng from develop to wittra. But accidentally, I made the change on the wrong repo (this repo) and instead of switching the base branch I renamed it. And somehow github deleted develop and closed all PRs... Many apologies for this mishap 🙏; I haven't contributed in a while.. but now at least everybody got some notification from me :p |
arurke
force-pushed
the
workaround-for-dao-garbled-2377
branch
from
14054a2
to
81ad651
Compare
arurke
force-pushed
the
workaround-for-dao-garbled-2377
branch
from
81ad651
to
5b09642
Compare
|
I have now rebased and removed the tests that were added via #2548. The logic in the tests have been reverted to verify this PR solves the issue. As mentioned I believe there is more work to be done on the issue (ref. my explanation above of why calling this a workaround) - at the same time I believe this PR is conservative and is unlikely to do any harm. |
This PR
Adds a test that showcases RPL No-path DAO spurred by forwarding errors have garbled contents #2377The test for the issue was added separately in Test cases for RPL issues 2377 and 2285 #2548. This PR simply reverts the logic in the test such that it passes only if the issue is resolved.In short, #2377 describes how No-Path DAOs that are sent when detecting RPL forwarding error will have garbled content and the receiver will discard it with error-log:
icmpv6 bad checksum. The workaround adds a small delay (next tick) to the generation of the DAO, and this resolves the issue. I am no uIP/RPL expert and I have not identified the root cause as to why the content is garbled (see some ideas in #2377). As such, I will have no trouble if we don't merge this and rather leave it for others to work onward from.For further details see test-description in #2548 and issue #2377.