Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to brd4184a and brd2601b #2826

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Yagoor
Copy link
Contributor

@Yagoor Yagoor commented Dec 27, 2023

No description provided.

@@ -114,16 +121,40 @@ GSDK_INC_PATHS += $(GSDK_ROOT)/platform/service/iostream/inc

### device_init
GSDK_C_SRCS += $(GSDK_ROOT)/platform/service/device_init/src/sl_device_init_nvic.c
ifeq ($(SL_SERIES),1)
GSDK_C_SRCS += $(GSDK_ROOT)/platform/service/device_init/src/sl_device_init_dcdc_s1.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the _s1.c with _s$(SL_SERIES).c instead of duplicating the entire block.

RAIL_FAMILY := efr32xg2x
SL_SERIES := 2

CFLAGS += -mfpu=fpv5-sp-d16 -mfloat-abi=hard -mcmse
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always enabling TrustZone?

-mcmse is already added by Makefile.arm when TRUSTZONE_SECURE_BUILD = 1.


CFLAGS += -mfpu=fpv5-sp-d16 -mfloat-abi=hard -mcmse

LDFLAGS += -mfpu=fpv5-sp-d16 -mfloat-abi=hard -mcmse
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need -mcmse in LDFLAGS.

/*---------------------------------------------------------------------------*/
#ifndef EFR32BG22C224F512IM40_CONF_H_
#define EFR32BG22C224F512IM40_CONF_H_
/*---------------------------------------------------------------------------*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has no contents, just avoid adding it.

@@ -73,6 +75,8 @@ dev/gpio-hal/zoul:BOARD=orion \
dev/leds/simplelink:BOARD=srf06/cc26x0 \
dev/leds/gecko:BOARD=brd4162a \
dev/leds/gecko:BOARD=brd4166a \
dev/leds/gecko:BOARD=brd4184a \
dev/leds/gecko:BOARD=brd2601b \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entries are (more or less) sorted alphabetically, so 2601 should come before 4162.

@pjonsson
Copy link
Contributor

I think the SDK update can go in a separate PR so it can be merged quickly. Is there any reason to not update to Gecko SDK 4.4.0 when you are making the effort of updating the SDK?

How similar are linkfile.ld? It would be nice if there could be one linkfile so changes only has to be made in one place per target(/board).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants