configure Vxlan veth interface mtu based on configured minimum host … #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseevr
reviewed
May 22, 2018
drivers/ovsd/ovsSwitch.go
Outdated
| @@ -100,6 +101,10 @@ func NewOvsSwitch(bridgeName, netType, localIP, fwdMode string, | |||
| sw.netType = netType | |||
| sw.uplinkDb = cmap.New() | |||
| sw.hostPvtNW = hostPvtNW | |||
| sw.vxlanEncapMtu, err = netutils.GetHostLowestLinkMtu() | |||
| if err != nil { | |||
| log.Fatalf("Failed to get Host Node MTU. Err:%v", err) | |||
There was a problem hiding this comment.
nitpick: add a space between : and %v
| @@ -359,7 +364,12 @@ func (sw *OvsSwitch) CreatePort(intfName string, cfgEp *mastercfg.CfgEndpointSta | |||
|
|
|||
| // Set the link mtu to 1450 to allow for 50 bytes vxlan encap | |||
| // (inner eth header(14) + outer IP(20) outer UDP(8) + vxlan header(8)) | |||
| err = setLinkMtu(intfName, vxlanEndpointMtu) | |||
| if sw.netType == "vxlan" { | |||
There was a problem hiding this comment.
Is there a constant you can use here instead of a string literal?
There was a problem hiding this comment.
There is no constant available ; same string literal has been used other part of code
There was a problem hiding this comment.
see this section of code:
sw.ovsdbDriver.ovsSwitch = sw
if netType == "vxlan" {
ofnetPort = vxlanOfnetPort
ctrlrPort = vxlanCtrlerPort
switch fwdMode {
case "bridge":
datapath = "vxlan"
case "routing":
datapath = "vrouter"
default:
dseevr
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…interface mtu
Description of the changes:
Currently container mtu in contiv network set as static MTU value as 1450. With this PR, contiv/netplugin
detect minimum configured mtu of host and cofingured Veth pair container side MTU to read MTU - 50 if container is part of Vxlan Bridge in OVS
Type of fix: Bug Fix
Fixes #1132
Please describe:
Contiv/netplugin bringup 2 types of OVS switch in every node and all container interface are plugged into these OVS switch based on OVS bridge mode type( Vlan or Vxlan). Incase of Vxlan , Container should not send packets more configured host Interface , to fix this issue, netplugin read lowest configured mtu in set of host interface and set container interface mtu 50 byte less if container interface is part OVS vxlan bridge
type of testing done (both manual and automated)
Bring up Contiv network with Vxlan encap as default switch.
Bringup container which is part of above contiv network .
check the configured interface MTU which should be 50 byte less than host minimum MTU
TODO