Epif cleanup #16
Epif cleanup #16
Conversation
| @@ -85,8 +85,6 @@ type EndpointDriver interface { | |||
| CreateEndpoint(id string) error | |||
| DeleteEndpoint(value string) error | |||
| MakeEndpointAddress() (*Address, error) | |||
| GetEndpointContainerContext(id string) (*ContainerEpContext, error) | |||
| GetContainerEpContextByContName(contName string) ([]ContainerEpContext, error) | |||
| UpdateContainerId(id string, contId string) error | |||
There was a problem hiding this comment.
Suggest to move the UpdateContainerId() out as well? Please ignore, if you were planning it for later.
There was a problem hiding this comment.
Update ContainerID is just a name of the function, there is nothing specific to container runtime there. I was hoping to not do updates to Ep record from oustide drivers code.
There was a problem hiding this comment.
hmm, it does imply that Endpoint driver Interface has something to do with containers, which is not the case.
Looks like this API updates the container-id in the EP oper-state in current implementation, should we just do it as part of attach/detach endpoint in the crt's logic? this looks more like some config meta for container runtime than network programming driver.
remove client dependency on modeldb
@mapuri - can you please review these changes; this moves container runtime out of netplugin. This is one of the target code cleanup work we identified. Please ignore the request from contiv account.