Add system tests #24
Merged
Add system tests #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, thanks Vipin! |
dseevr
pushed a commit
to dseevr-dev/netplugin
that referenced
this pull request
Nov 28, 2017
…v#24) * Support for external contracts (provided and consumed) for ACI * Add tenant as part of the key for external contracts object * Just have a single link-set for all contract groups * Just have a single external contracts array at the epg level. * Add validators for contracts group name and tenant name for the external contracts object
dseevr
pushed a commit
to dseevr-dev/netplugin
that referenced
this pull request
Nov 28, 2017
* - add version in api - add cfgProperties adn operProperties * fix linksets with operstate * add versioning in api, other fixes * add network oper proerties * avoid generating operlinks * avoid operlinks for client code gen * global oper state * Support for external contracts (provided and consumed) for ACI (contiv#24) * Support for external contracts (provided and consumed) for ACI * Add tenant as part of the key for external contracts object * Just have a single link-set for all contract groups * Just have a single external contracts array at the epg level. * Add validators for contracts group name and tenant name for the external contracts object * merge contract groups change * rebase to latest * add versioning in api, other fixes * add network oper proerties * avoid generating operlinks * avoid operlinks for client code gen * global oper state * add version to external contracts object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the systests API to simplify the systests use cases. Added automated system tests for 1) multi-host vxlan topology 2) change in desired state 3) add/delete elements to existing configuration.
These tests ensure more scrutiny to the new code, but increases test time thus we need to discuss if we should create separate directory for regression suite and keep it different from system tests.
Comments welcome!