Pass Id as input to DeleteNetwork and DeleteEndpoint APIs #25
Conversation
mapuri
force-pushed
the
deleteApiCleanup
branch
from
20e3382
to
9177cd3
Compare
This commit reverts the DeleteNetwork and DeleteEndpoint APIs to taking network and endpoint Ids as input instead of an opaque value string. This follows the netplugin design to keep driver specific state handling inside the driver than the Netplugin Core.
mapuri
force-pushed
the
deleteApiCleanup
branch
from
9177cd3
to
1685046
Compare
Pass Id as input to DeleteNetwork and DeleteEndpoint APIs
|
looks good @mapuri |
|
@jainvipin yes, I didn't find any such case yet. Having said that, as we were discussing earlier it is because right now we are dealing with not depending on state in config by keeping state necessary for handling delete in oper state as well. Usually this should be ok and is simple to implement. But if it results in some kind of state bloat we can address it by keeping a some kind of shadow copy of config states around so that we can hold that state a little longer until all cleanup is done, but all that can be hidden under the state-driver and state itself instead of exposing it to network/endpoint drivers or the management-function. |
* - add version in api - add cfgProperties adn operProperties * fix linksets with operstate * add versioning in api, other fixes * add network oper proerties * avoid generating operlinks * avoid operlinks for client code gen * global oper state * Support for external contracts (provided and consumed) for ACI (contiv#24) * Support for external contracts (provided and consumed) for ACI * Add tenant as part of the key for external contracts object * Just have a single link-set for all contract groups * Just have a single external contracts array at the epg level. * Add validators for contracts group name and tenant name for the external contracts object * merge contract groups change * rebase to latest * add versioning in api, other fixes * add network oper proerties * avoid generating operlinks * avoid operlinks for client code gen * global oper state * add version to external contracts object
This commit reverts the DeleteNetwork and DeleteEndpoint APIs back to taking network
and endpoint Ids as input instead of an opaque value strings. This follows the netplugin
design to keep driver specific state handling inside the driver than the Netplugin Core.