Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin support for progress bar box drawing (inspired by Fira Code) #521

Closed
christianparpart opened this issue Dec 2, 2021 · 7 comments
Labels
enhancement New feature or request fonts font rasterization and text shaping API and platform implementations good first issue Good for newcomers VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library
Milestone

Comments

@christianparpart
Copy link
Member

For reference: tonsky/FiraCode#1182

Fira Code actually had an amazing idea of making progress bars pretty. We could get users to make use of these code points even though their fonts do not support it.

@christianparpart christianparpart added enhancement New feature or request good first issue Good for newcomers VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library fonts font rasterization and text shaping API and platform implementations labels Dec 2, 2021
@WSLUser
Copy link

WSLUser commented Dec 10, 2021

If you were using XAML, I'd say you could easily set up progress bars as that's what WT did, though that also makes them accept all the bugs with it too and there are a couple still out there on the WinUI repo. But since you're using QT, I'd wonder how another QT based terminal does it, if it's supported by the terminal.

Or are you looking to do it in the client drawing area, not the UI? That would explain wishing to do similar to FiraCode.

@uspasojevic96
Copy link
Member

If you were using XAML, I'd say you could easily set up progress bars as that's what WT did, though that also makes them accept all the bugs with it too and there are a couple still out there on the WinUI repo. But since you're using QT, I'd wonder how another QT based terminal does it, if it's supported by the terminal.

Or are you looking to do it in the client drawing area, not the UI? That would explain wishing to do similar to FiraCode.

what does a markup language have to do with framework?

@christianparpart
Copy link
Member Author

Oh I think you are misunderstanding something, accidentally. This is about rendering progress bars as part of the grid system, by making codepoints to manually created bitmaps, just like pixel perfect box drawing.

@WSLUser
Copy link

WSLUser commented Dec 10, 2021

So not something you'd show in a tab or pane when you eventually have those too then.

@christianparpart
Copy link
Member Author

So not something you'd show in a tab or pane when you eventually have those too then.

image

These are regular codepoints, just like letters and digets, or box-drawing characters. See the link above :)

@christianparpart christianparpart added this to the 0.3.0 milestone Feb 22, 2022
@christianparpart
Copy link
Member Author

Note to myself: tonsky/FiraCode#1324 (comment)

@christianparpart
Copy link
Member Author

EE00..EE05 implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fonts font rasterization and text shaping API and platform implementations good first issue Good for newcomers VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library
Projects
None yet
Development

No branches or pull requests

3 participants