Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAN in in edb-gaseous-v29b-engines.csv #215

Closed
depion opened this issue Jul 4, 2024 · 3 comments · Fixed by #218
Closed

NAN in in edb-gaseous-v29b-engines.csv #215

depion opened this issue Jul 4, 2024 · 3 comments · Fixed by #218
Assignees
Labels
bug Something isn't working

Comments

@depion
Copy link

depion commented Jul 4, 2024

Description

In the table https://github.com/contrailcirrus/pycontrails/blob/98008ed98690f62d72027596cf23a5930c9a7c61/pycontrails/models/emissions/static/edb-gaseous-v29b-engines.csv there is an entry for UID 1ZM001 which has no entry/nan for Fuel Flow Idle (kg/sec) . This leads to a problem if the EmissionsProfileInterpolator is applied to this data, finally raising an exception here: https://github.com/contrailcirrus/pycontrails/blob/main/pycontrails/core/interpolation.py#L674

Details

  • Version: pycontrails[complete]==0.50.2
@depion depion added the bug Something isn't working label Jul 4, 2024
@mlshapiro
Copy link
Contributor

@roger-teoh can you please look into the entry in this CSV file?

@roger-teoh
Copy link
Collaborator

Hi Dennis, thank you for spotting this error! I had a look at it and can confirm that the value is also missing in the original ICAO EDB v29b dataset.

In all previous versions, we typically remove engines that contain missing fuel mass flow rate values. However, for this case, given that the engine characteristics of 1ZM001 is completely identical to 13ZM002, I have implemented a simple fix by filling the missing Fuel Flow Idle (kg/sec) value with those provided by the 13ZM002 engine. This minor change will be merged into the pycontrails repository pending approval from @mlshapiro

@mlshapiro
Copy link
Contributor

Merged - this will get pushed to pypi on the next release, but available if you pull main!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants