Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request #5

Open
elmoalso opened this issue Dec 19, 2022 · 2 comments
Open

Feature Request #5

elmoalso opened this issue Dec 19, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@elmoalso
Copy link

Any actions that check for the value of a tag are looking for an exact value from the read or the test fails. I am especially interested in the case of a Unit test when I can only test for a exact value to be reached in an exact amount of time. As the test exists now, I don't believe I can test a PID loop easily to ensure that it is correctly configured for normal or reverse acting. When I am testing or training operators I have a PIDE simulator that just allows me to tell it the EU range and whether it should simulate direct or reverse acting control. It then uses 2nd or filtering to move a simulated PV toward the SP. I don't want to change the actual PID constants in the loop so I just take a stab at deadtime and 2nd order filter time in my simulator to ensure I capture whether or not the loop is responding in the correct direction
If I could could configure a test that says:

reaches a value of xx.xx or greater (rather than an exact value) within x seconds (rather than getting to the value in a precise amount of time) I could then test to see that the PID loop is configured correctly or not.
2022-12-19_14-12-33

@alex-controlx
Copy link
Member

this is a bit late reply, I guess.
This is a good feature request, it actually was next on the roadmap. There planned to be a new action Set Raising Value which will increase the value by a step or within a timeframe.

To test rising value is possible with the current Action Units by testing for a value every 5 seconds. For instance, Process_PV expected to be 10 after 5 seconds, Process_PV expected to be 18 after 10 seconds, Process_PV expected to be 26 after 15 seconds, etc.

Also current project is on hold at the moment, it will be open sourced soon so the community can contribute.

@elmoalso
Copy link
Author

Aha, thank you Alex

@alex-controlx alex-controlx added the enhancement New feature or request label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants